fix(ext/node): unref child_process stdio streams by default#32071
Merged
fraidev merged 2 commits intodenoland:mainfrom Feb 6, 2026
Merged
fix(ext/node): unref child_process stdio streams by default#32071fraidev merged 2 commits intodenoland:mainfrom
fraidev merged 2 commits intodenoland:mainfrom
Conversation
31d2905 to
f5f8773
Compare
cfb533e to
2d6c2c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32064
PR #31975 made child process stdio streams into Socket instances backed by Pipe → StreamResource. When libraries like esbuild call
child.unref()/stdout.unref()to signal the event loop should be free to exit, the call chain was Socket.unref() → Pipe.unref() → only unrefs#listener(null for non-server pipes) → StreamResource never gets unref'd → process hangs.With this fix, Pipe.unref() also propagates to the stream in
[kStreamBaseField], so esbuild's unref calls reach the StreamResource and the event loop can exit properly.