fix(ext/node): make child_process stdio streams Socket instances#31975
Merged
fraidev merged 4 commits intodenoland:mainfrom Feb 2, 2026
Merged
fix(ext/node): make child_process stdio streams Socket instances#31975fraidev merged 4 commits intodenoland:mainfrom
child_process stdio streams Socket instances#31975fraidev merged 4 commits intodenoland:mainfrom
Conversation
e58d5f4 to
41e4f03
Compare
41e4f03 to
11ea6da
Compare
bartlomieju
reviewed
Jan 29, 2026
| @@ -164,18 +167,46 @@ class StreamResource implements StreamBase { | |||
| } | |||
| async read(p: Uint8Array): Promise<number | null> { | |||
Member
There was a problem hiding this comment.
What if this gets called multiple times? Is that possible? If so then you will overwrite pending promise
Contributor
Author
There was a problem hiding this comment.
Good catch! I changed to use a Set of it instead
bartlomieju
reviewed
Jan 29, 2026
| } | ||
| write(p: Uint8Array): Promise<number> { | ||
| return core.write(this.#rid, p); | ||
| async write(p: Uint8Array): Promise<number> { |
child_process stdio streams Socket instances
|
Awesome! Thanks yall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31961
Closes #25602
This PR fixes child process stdio streams (
stdin,stdout,stderr) to be instances ofSocketfromnode:net, matching Node.js behavior.