feat(node): implement FileHandle.readv() method#31943
Merged
Tango992 merged 2 commits intodenoland:mainfrom Jan 24, 2026
Merged
feat(node): implement FileHandle.readv() method#31943Tango992 merged 2 commits intodenoland:mainfrom
FileHandle.readv() method#31943Tango992 merged 2 commits intodenoland:mainfrom
Conversation
Adds the missing `readv` method to the FileHandle class in node:fs/promises, which reads data into an array of ArrayBufferView buffers.
|
|
616fbfe to
0c16fc9
Compare
bartlomieju
reviewed
Jan 24, 2026
Member
bartlomieju
left a comment
There was a problem hiding this comment.
Are there Node compat tests that could be enabled with this change?
Contributor
Author
I think test-fs-readv-promises.js should cover this |
nayeemrmn
added a commit
to nayeemrmn/deno
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
filehandle.readv(buffers[, position])method for theFileHandleclass innode:fs/promises.This is part of #25554 tracking
FileHandlemissing methods.References: Node.js docs: https://nodejs.org/api/fs.html#filehandlereadvbuffers-position
Changes
ReadVResultinterface andreadvPromisefunction in_fs_readv.tsreadvmethod toFileHandleclass inhandle.tsreadvwith and without position parameter