fix(ext/node): support numbered positional parameters in node:sqlite#31722
Merged
magurotuna merged 3 commits intodenoland:mainfrom Jan 1, 2026
Merged
fix(ext/node): support numbered positional parameters in node:sqlite#31722magurotuna merged 3 commits intodenoland:mainfrom
magurotuna merged 3 commits intodenoland:mainfrom
Conversation
SQLite numbered positional parameters (?1, ?2, ?NNN) were incorrectly treated as named parameters and skipped during binding, causing a "column index out of range" error. This fix updates the parameter binding logic to recognize that parameters whose names start with '?' are positional and should be bound in order, just like anonymous parameters (?).
ayuusweetfish
pushed a commit
to ayuusweetfish/deno
that referenced
this pull request
Jan 3, 2026
…enoland#31722) SQLite numbered positional parameters (?1, ?2, ?NNN) were incorrectly treated as named parameters and skipped during binding, causing a "column index out of range" error. This fix updates the parameter binding logic to recognize that parameters whose names start with '?' are positional and should be bound in order, just like anonymous parameters (?). Fixes denoland#31719 (cherry picked from commit d08d790)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite numbered positional parameters (?1, ?2, ?NNN) were incorrectly
treated as named parameters and skipped during binding, causing a
"column index out of range" error. This fix updates the parameter
binding logic to recognize that parameters whose names start with '?'
are positional and should be bound in order, just like anonymous
parameters (?).
Fixes #31719