fix(ext/web): make DOMException properly serializable#31156
Closed
fix(ext/web): make DOMException properly serializable#31156
Conversation
d560b94 to
9b1f28f
Compare
bartlomieju
added a commit
to denoland/deno_core
that referenced
this pull request
Nov 5, 2025
denoland/deno#31156 --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
petamoriken
reviewed
Jan 29, 2026
Comment on lines
+62
to
+65
| const de = structuredClone(new DOMException("message", "SomeError")); | ||
| assert(de instanceof DOMException); | ||
| assertEquals(de.message, "message"); | ||
| assertEquals(de.name, "SomeError"); |
Contributor
There was a problem hiding this comment.
We need to copy the stack property as well
Member
|
Closing in favor of #32675 |
bartlomieju
added a commit
that referenced
this pull request
Mar 13, 2026
## Summary - Enables `structuredClone()` and `postMessage()` for `DOMException` objects using the cloneable resource registry from #32672 - Serializes `message`, `name`, and `stack`; `code` is derived from `name` on deserialization - Supersedes #31156 Ref #31126 (comment) Closes #31983 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
denoland/deno_core#1220