fix(ext/node): add a createReadStream & createWriteStream methods to the FileHandle class#28700
Merged
kt3k merged 2 commits intodenoland:mainfrom Apr 7, 2025
Merged
Conversation
SebastienGllmt
commented
Apr 1, 2025
| ); | ||
|
|
||
| Deno.test( | ||
| "[node/fs filehandle.createWriteStream] Create a write stream", |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if these tests are meant to be taken from somewhere
The definition of the createReadStream test I took from #27591
The definition of the createWriteStream test I wrote myself trying to follow the same style
SebastienGllmt
commented
Apr 1, 2025
This was referenced Apr 1, 2025
93b2e2b to
9337f3e
Compare
kt3k
approved these changes
Apr 7, 2025
Contributor
kt3k
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Simplified the createWriteStream test case to avoid the flakiness in CI
nayeemrmn
pushed a commit
that referenced
this pull request
Apr 11, 2025
…e FileHandle class (#28700) Co-authored-by: Nikolay Karadzhov <nkaradzhov89@gmail.com> Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the missing support for
createReadStreamandcreateWriteStreamon theFileHandlerclass (as outlined in #25554)Notably, it does so by building on top of #27591 which was presumably abandoned