fix(ext/node): add FileHandle#sync#27677
Merged
kt3k merged 5 commits intodenoland:mainfrom Jan 21, 2025
Merged
Conversation
|
|
a9f2d87 to
6e803d2
Compare
f1b298f to
e250b23
Compare
kt3k
approved these changes
Jan 21, 2025
Contributor
kt3k
left a comment
There was a problem hiding this comment.
It's great to see a node compat case enabled. LGTM!
crowlKats
pushed a commit
that referenced
this pull request
Jan 21, 2025
(cherry picked from commit 4e0bf4b)
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds sync methods of FileHandle class https://nodejs.org/api/fs.html#fs_filehandle_sync
part of #25554