fix(node/fs): add utimes method to the FileHandle class#27582
Merged
kt3k merged 4 commits intodenoland:mainfrom Jan 14, 2025
Merged
fix(node/fs): add utimes method to the FileHandle class#27582kt3k merged 4 commits intodenoland:mainfrom
kt3k merged 4 commits intodenoland:mainfrom
Conversation
|
|
Contributor
Author
|
Actually, some of the remaining methods can be implemented quickly. Would a mass PR be okay? |
kt3k
approved these changes
Jan 14, 2025
Contributor
kt3k
left a comment
There was a problem hiding this comment.
LGTM. Thanks
Would a mass PR be okay?
Further contributions are welcome
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added utimes method to the FileHandle class, part of #25554
✔ cargo test
✔ tools/format
✔ tools/lint