fix(ext/node): add fs.promises.fstat and FileHandle#stat#26719
Merged
kt3k merged 12 commits intodenoland:mainfrom Nov 25, 2024
Merged
fix(ext/node): add fs.promises.fstat and FileHandle#stat#26719kt3k merged 12 commits intodenoland:mainfrom
fs.promises.fstat and FileHandle#stat#26719kt3k merged 12 commits intodenoland:mainfrom
Conversation
bd5b907 to
bc98058
Compare
manzt
commented
Nov 4, 2024
e3b22c0 to
e369177
Compare
e369177 to
a70a10c
Compare
fstat and implement FileHandle#stat
Contributor
Author
|
Oops, seeing #24391. Feel free to close. Although, I don't think that PR handles checking the whether the file is open prior to executing the fs operations. Probably should use the |
fstat and implement FileHandle#statfs.promises.fstat and FileHandle#stat
kt3k
approved these changes
Nov 25, 2024
Contributor
kt3k
left a comment
There was a problem hiding this comment.
Sorry for the initial confusing comment. This now looks good to me. Nice work!
This was referenced Nov 25, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Nov 28, 2024
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23301
Implements
FileHandle.stat. This PR also adds a promisifiedfs.fstatunder 'fs/promises', which is used internally byFileHandle.stat.part of #25554