feat(node_compat): Add a write method to the FileHandle class#19385
Merged
mmastrac merged 11 commits intodenoland:mainfrom Jun 8, 2023
Merged
feat(node_compat): Add a write method to the FileHandle class#19385mmastrac merged 11 commits intodenoland:mainfrom
mmastrac merged 11 commits intodenoland:mainfrom
Conversation
Contributor
Author
|
Looking at the latest Node documentation, it appears that the write method accepts an option as an argument, but I don't see such a definition in DefinitelyTyped/blob/d9df51e34526f48bef4e2546a006157b391ad96c/types/node/fs.d.ts. I will investigate further at a later date. append: Understood that it is node 17.x |
…to k-nasa/feat_write
Contributor
Author
|
CI seems to be falling in unrelated places.. |
Contributor
Author
|
@mmastrac I would be happy if you could review it. 🙏 |
mmastrac
reviewed
Jun 8, 2023
bartlomieju
pushed a commit
that referenced
this pull request
Jun 8, 2023
## WHY ref: #19165 The FileHandle class has many missing methods compared to node. ## WHAT Add write method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
ref: #19165
The FileHandle class has many missing methods compared to node.
WHAT
Add write method