[Kernel] Fix the partition path construction#3290
Merged
Merged
Conversation
vkorukanti
commented
Jun 21, 2024
| */ | ||
| public String getTargetDirectory() { | ||
| return targetDirectory; | ||
| // TODO: this is temporary until paths are uniform (i.e. they are actually file system paths |
Collaborator
Author
There was a problem hiding this comment.
This will be fixed as part of PR that changes all APIs to use the path. Currently we use paths some places and URI in others. This PR is coming next.
scottsand-db
approved these changes
Jun 21, 2024
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Aug 30, 2024
## Description The current code does not escape the control + special characters in partition values when constructing a path for writing the data related to the partition. Not escaping these characters could cause invalid path issues. The escaping logic is similar to what Spark and Hive do. ## How was this patch tested? Unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current code does not escape the control + special characters in partition values when constructing a path for writing the data related to the partition. Not escaping these characters could cause invalid path issues.
The escaping logic is similar to what Spark and Hive do.
How was this patch tested?
Unit tests.