Increase code coverage#81
Merged
Merged
Conversation
a8fa4c6 to
8506521
Compare
d6bb6dc to
85deeac
Compare
anathoodell
previously approved these changes
Feb 11, 2025
donatwork
previously approved these changes
Feb 12, 2025
Contributor
|
Can you run e2e with the changes as we are modifying go files also to make sure we are not introducing any breaking changes. |
bpjain2004
previously approved these changes
Feb 12, 2025
Contributor
Author
|
@chimanjain, the changes to the Go files primarily involve converting unexported variables to exported ones, which was necessary for writing the unit tests. No changes have been made to the functionality. |
HarishH-DELL
previously approved these changes
Feb 12, 2025
Contributor
|
Thanks @AkshaySainiDell for clarifying. LGTM |
chimanjain
previously approved these changes
Feb 12, 2025
2bc9da8
…scale into chore-code-coverage
alikdell
approved these changes
Feb 19, 2025
atye
approved these changes
Feb 19, 2025
donatwork
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
Increases code coverage to the required levels per our standards. Unit tests were run. Cert-csi was used to run the provisioning and volume IO tests.
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
This PR increases the UT coverage