Remove private json package in favor of encoding/json#93
Merged
Conversation
ChristianAtDell
approved these changes
Feb 19, 2025
alikdell
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
Remove the older internal version of the json package and instead use the now mature and maintained encoding/json package. This was a drop in replacement as the internal code was from an earlier version of encoding/json. There was one customization of importance which relied on a custom unmarshall directive to prevent marshalling the ID field but still allow unmarshalling of the field. I did not see a modern way of doing that, other than a custom unmarshaller. Given that it is standard practice to separate the request and response structures I opted to use a separate structure, ExportReq for (PUT, POST) requests and the normal Export for responses. Unit tests pass and I ran cert-csi provisioning and volume IO tests.
GitHub Issues
Common PR Checklist:
Description of your changes: