CSI-PowerMax driver incorrectly labelling nodes for nfs protocol#97
Merged
Conversation
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
5 tasks
nitesh3108
approved these changes
Jun 23, 2025
niranjan-n1
approved these changes
Jun 23, 2025
donatwork
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added methods to provide the details of the NFS servers. These are consumed by the csi-powermax driver, NodeGetInfo() to check if the array in question has the NFS configured in it, and accordingly set the topology keys/labels for the node objects.
Corresponding csi-powermax PR: dell/csi-powermax#550
GitHub Issues
Checklist:
How Has This Been Tested?
New unit tests are added and all the existing unit tests are executed with any failures.
Deployed the csi-powermax driver with these changes and driver able to query the NFS details using the new methods.