Skip to content

CSI-PowerMax driver incorrectly labelling nodes for nfs protocol#550

Merged
bpjain2004 merged 2 commits into
mainfrom
usr/bjain/nfs-lables
Jun 23, 2025
Merged

CSI-PowerMax driver incorrectly labelling nodes for nfs protocol#550
bpjain2004 merged 2 commits into
mainfrom
usr/bjain/nfs-lables

Conversation

@bpjain2004

@bpjain2004 bpjain2004 commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add nfs labels for topology keys only when the corresponding NFS servers are enabled on the array.

Corresponding gopowermax PR: dell/gopowermax#97

GitHub Issues

GitHub Issue #
https://github.com/dell/csm/issues/1808

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?

How Has This Been Tested?

  • New unit tests are added to cover the new code.
  • Deployed the driver with these changes successfully.
    • Deployed the driver with the array configured with NFS server, observed that nfs labels are added to the nodes(with array connectivity).
    • Deployed the driver with the array configured without NFS server and Iscsi connectivity. Only the Iscsi labels are added to the node objects.
    • Deployed the driver with the array configured with NFS server and Iscsi connectivity. The Iscsi and nfs labels are added to the node objects.
    • Created PVCs and Pods successfully during the above verification.
      All the verification logs are uploaded to the jira ticket.

@bpjain2004 bpjain2004 requested a review from nitesh3108 June 19, 2025 16:04
@github-actions

github-actions Bot commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/pkg/symmetrix/mocks 0.00% (ø)
github.com/dell/csi-powermax/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powermax/pkg/symmetrix/mocks/pmaxclient.go 0.00% (ø) 0 0 0
github.com/dell/csi-powermax/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powermax/service/node_test.go

@bpjain2004 bpjain2004 changed the title [DRAFT] ECS01C-246: CSI-PowerMax driver incorrectly labelling nodes for nfs protocol [DRAFT] CSI-PowerMax driver incorrectly labelling nodes for nfs protocol Jun 20, 2025
@bpjain2004 bpjain2004 mentioned this pull request Jun 20, 2025
Merged
7 tasks
@bpjain2004 bpjain2004 changed the title [DRAFT] CSI-PowerMax driver incorrectly labelling nodes for nfs protocol CSI-PowerMax driver incorrectly labelling nodes for nfs protocol Jun 20, 2025
@bpjain2004 bpjain2004 merged commit 820c0f7 into main Jun 23, 2025
6 checks passed
@bpjain2004 bpjain2004 deleted the usr/bjain/nfs-lables branch June 23, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

3 more reviewers

@donatwork donatwork donatwork approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bpjain2004 @donatwork @nitesh3108 @niranjan-n1