Skip to content

Support nvme-cli 2.11 (OCP 4.19, RHEL9.6, RCOS 9.6)#81

Merged
donatwork merged 7 commits into
mainfrom
usr/dkhan/nvme-211-enhancements
Jun 23, 2025
Merged

Support nvme-cli 2.11 (OCP 4.19, RHEL9.6, RCOS 9.6)#81
donatwork merged 7 commits into
mainfrom
usr/dkhan/nvme-211-enhancements

Conversation

@donatwork

@donatwork donatwork commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Description

Support nvme-cli 2.11 which uses a different format in the nvme list -o json results. This release is used in OCP 4.19 and RHEL/RCOS 9.6 releases.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896
https://github.com/dell/csm/issues/1939

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested provisioning and IO on OCP 4.18 using NVMeTCP protocol on PowerStore (regression)
  • Tested provisioning and IO on OCP 4.19 using NVMeTCP protocol on PowerStore (regression)

@donatwork donatwork force-pushed the usr/dkhan/nvme-211-enhancements branch from 5d4f721 to e486bdc Compare June 20, 2025 19:50
@donatwork donatwork requested a review from satyakonduri June 23, 2025 09:07
Comment thread gonvme_tcp_fc.go
@donatwork donatwork requested a review from satyakonduri June 23, 2025 14:33
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gonvme 90.25% (+0.17%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gonvme/gonvme_tcp_fc.go 86.29% (+0.34%) 372 (+9) 321 (+9) 51 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gonvme/gonvme_tcp_fc_test.go

@donatwork donatwork merged commit 71afc94 into main Jun 23, 2025
6 checks passed
@donatwork donatwork deleted the usr/dkhan/nvme-211-enhancements branch June 23, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants