Skip to content

Added new env for volume prefix#974

Merged
niranjan-n1 merged 0 commit into
mainfrom
usr/niranjan/snapshot-volprefix
May 7, 2025
Merged

Added new env for volume prefix#974
niranjan-n1 merged 0 commit into
mainfrom
usr/niranjan/snapshot-volprefix

Conversation

@niranjan-n1

@niranjan-n1 niranjan-n1 commented May 5, 2025

Copy link
Copy Markdown
Contributor

Description

Added new env variable X_CSI_VOL_PREFIX

Associated PRs:
dell/csi-powerscale#383
dell/helm-charts#715
dell/csm-docs#1521

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1487

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • E2E test for authorization and snapshot tests using cert-csi have been performed using PowerScale driver deployed by an Operator image that was built on this branch.

auth-e2e-full-output.log
cert-csi-isilon-operator.log

image

Comment thread operatorconfig/driverconfig/powerscale/v2.14.0/controller.yaml Outdated
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-operator/pkg/drivers 96.91% (-0.08%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-operator/pkg/drivers/powerscale.go 98.92% (-1.08%) 93 (+4) 92 (+3) 1 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@rajkumar-palani rajkumar-palani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niranjan-n1 niranjan-n1 merged commit 12076f8 into main May 7, 2025
6 checks passed
@niranjan-n1 niranjan-n1 deleted the usr/niranjan/snapshot-volprefix branch May 7, 2025 10:48

@chaganti-rajitha chaganti-rajitha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants