Skip to content

gobrick module update#225

Merged
suryagupta4 merged 1 commit into
mainfrom
golibupdate
Aug 8, 2024
Merged

gobrick module update#225
suryagupta4 merged 1 commit into
mainfrom
golibupdate

Conversation

@suryagupta4

@suryagupta4 suryagupta4 commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Description

gobrick module update for the scsi rescan fix dell/gobrick#54

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1379

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • driver pods running with latest gobrick
    image

  • cert-csi
    image

Signed-off-by: Surya <surya.gupta1@dell.com>

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryagupta4 suryagupta4 merged commit d2774c2 into main Aug 8, 2024
@suryagupta4 suryagupta4 deleted the golibupdate branch August 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants