Skip to content

Updates scsi rescan to use the LUN number in rescan command#54

Merged
delldubey merged 1 commit into
mainfrom
lun_rescan
Jul 18, 2024
Merged

Updates scsi rescan to use the LUN number in rescan command#54
delldubey merged 1 commit into
mainfrom
lun_rescan

Conversation

@delldubey

@delldubey delldubey commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

Description

This PR:

  • This updates the rescan logic in findHCTLsForFCHBA function to use LUN number instead of '-', which scans for all the luns on a host.
  • The LUN number is primarily part of NodeStageRequest.
  • This saves us the issue of having a ghost/invalid sd* disk post NodeUnstage and there is a rescan for new devices at the same time.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1379

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test
  • Cluster test

donatwork
donatwork approved these changes Jul 18, 2024
View reviewed changes

@donatwork donatwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely do some regression testing with PowerStore.

@delldubey delldubey merged commit cacb47e into main Jul 18, 2024
@suryagupta4 suryagupta4 mentioned this pull request Aug 8, 2024
Merged
10 tasks
@donatwork donatwork mentioned this pull request Aug 12, 2024
Merged
9 tasks
@anandrajak1 anandrajak1 deleted the lun_rescan branch October 17, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

4 more reviewers

@donatwork donatwork donatwork approved these changes

@alexemc alexemc alexemc approved these changes

@francis-nijay francis-nijay francis-nijay approved these changes

@anathoodell anathoodell anathoodell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@delldubey @donatwork @alexemc @francis-nijay @anathoodell