Skip to content

Remove sharednfs codes that starts node monitor services that affects performance#509

Merged
xuluna merged 7 commits into
mainfrom
usr/luna/fix-performance
Jul 2, 2025
Merged

Remove sharednfs codes that starts node monitor services that affects performance#509
xuluna merged 7 commits into
mainfrom
usr/luna/fix-performance

Conversation

@xuluna

@xuluna xuluna commented Jun 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The PR comments out csm-sharednfs codes that starts node monitor services that affects performance. This commented block needs to be re-enabled later for sharednfs feature.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1930

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test:
# make test
cd ./pkg; go test -race -cover -coverprofile=coverage.out ./...
ok      github.com/dell/csi-powerstore/v2/pkg/array     1.414s  coverage: 96.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common    3.233s  coverage: 96.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common/fs 1.150s  coverage: 90.6% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common/k8sutils   2.092s  coverage: 90.8% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/controller        2.100s  coverage: 90.5% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/identity  1.128s  coverage: 100.0% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/interceptors      3.968s  coverage: 90.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/node      4.168s  coverage: 90.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/provider  1.204s  coverage: 100.0% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/service   1.186s  coverage: 94.4% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/tracer    1.124s  coverage: 100.0% of statements
  • Integration test:
 # ./cert-csi certify --cert-config samples/powerstore-certify-config.yaml --ns powerstore --nm
....
[-----------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s[2025-06-28 08:03:23]  INFO Avg time of a run:   57.29s
[2025-06-28 08:03:23]  INFO Avg time of a del:   16.77s
[2025-06-28 08:03:23]  INFO Avg time of all:     74.14s
[2025-06-28 08:03:23]  INFO During this run 100.0% of suites succeeded

@xuluna xuluna force-pushed the usr/luna/fix-performance branch from b359c52 to 6b1a988 Compare June 30, 2025 13:10
lukeatdell
lukeatdell previously approved these changes Jun 30, 2025
View reviewed changes
bharathsreekanth
bharathsreekanth previously approved these changes Jul 1, 2025
View reviewed changes
Comment thread pkg/service/service.go Outdated
@xuluna xuluna dismissed stale reviews from bharathsreekanth and lukeatdell via 33def2f July 2, 2025 13:42
@xuluna xuluna marked this pull request as ready for review July 2, 2025 13:54
@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

falfaroc
falfaroc reviewed Jul 2, 2025
View reviewed changes
Comment thread pkg/service/service.go
donatwork
donatwork approved these changes Jul 2, 2025
View reviewed changes

@donatwork donatwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it makes sense to use an environment variable to toggle the features?

@xuluna

xuluna commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Does it makes sense to use an environment variable to toggle the features?

Yes we will consider that in the future when we revisit this feature.

@xuluna xuluna merged commit 1364f31 into main Jul 2, 2025
16 of 18 checks passed
@xuluna xuluna deleted the usr/luna/fix-performance branch July 2, 2025 15:24
WilsonRadadia20 pushed a commit that referenced this pull request Jul 9, 2025
@xuluna @WilsonRadadia20
Remove sharednfs codes that starts node monitor services that affects…
acfadd5 
… performance (#509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

2 more reviewers

@falfaroc falfaroc falfaroc approved these changes

@donatwork donatwork donatwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuluna @falfaroc @donatwork @bharathsreekanth @lukeatdell