Skip to content

Fix: Unmounting HBNFS Volume#476

Merged
falfaroc merged 6 commits into
mainfrom
usr/falfaroc/unmountvolume-testing
May 1, 2025
Merged

Fix: Unmounting HBNFS Volume#476
falfaroc merged 6 commits into
mainfrom
usr/falfaroc/unmountvolume-testing

Conversation

@falfaroc

@falfaroc falfaroc commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix detection of mounted Shared NFS volumes and only try to unmount them if they do exist.

Note: Pending on merging of dell/csm-sharednfs#25.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1742

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test reassignment when a node goes down (reboot/shutdown) and clearing of exports/mounts when the node comes back up.
  • Ensure that normal deletion of Shared NFS exports/mounts are cleared.

xuluna
xuluna previously approved these changes Apr 29, 2025
View reviewed changes
kumarp20
kumarp20 previously approved these changes May 1, 2025
View reviewed changes
@falfaroc falfaroc dismissed stale reviews from kumarp20 and xuluna via d573869 May 1, 2025 14:15
@falfaroc falfaroc requested review from kumarp20 and xuluna May 1, 2025 14:15
@github-actions

github-actions Bot commented May 1, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/service/node.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/service/node_test.go

@falfaroc falfaroc marked this pull request as ready for review May 1, 2025 14:18
@falfaroc falfaroc merged commit b77cc60 into main May 1, 2025
6 checks passed
@falfaroc falfaroc deleted the usr/falfaroc/unmountvolume-testing branch May 1, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@donatwork donatwork Awaiting requested review from donatwork

3 more reviewers

@xuluna xuluna xuluna approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@falfaroc @xuluna @bharathsreekanth @kumarp20 @santhoshatdell