Skip to content
This repository was archived by the owner on Sep 24, 2025. It is now read-only.

Fix: Reassignment Process#25

Merged
falfaroc merged 9 commits into
mainfrom
usr/falfaroc/reassignment-testing
May 1, 2025
Merged

Fix: Reassignment Process#25
falfaroc merged 9 commits into
mainfrom
usr/falfaroc/reassignment-testing

Conversation

@falfaroc

@falfaroc falfaroc commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Description

Adjust the processing of the reassignment to ensure that we only remove exports that have associated services.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1742

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test to ensure that the exports are only removed which have associated services.

xuluna
xuluna previously approved these changes Apr 29, 2025
Comment thread nfs/exports.go
Comment thread nfs/nfs_service.go Outdated
lukeatdell
lukeatdell previously approved these changes May 1, 2025
Comment thread nfs/exports.go
Comment thread nfs/controller.go Outdated
@falfaroc falfaroc dismissed stale reviews from bharathsreekanth and lukeatdell via afe5635 May 1, 2025 13:48
@falfaroc falfaroc requested a review from tdawe May 1, 2025 13:49
@github-actions

github-actions Bot commented May 1, 2025

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-hbnfs/nfs 90.46% (+0.09%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-hbnfs/nfs/controller.go 88.84% (+0.05%) 233 (+1) 207 (+1) 26 👍
github.com/dell/csm-hbnfs/nfs/exports.go 91.34% (-0.26%) 127 (-4) 116 (-4) 11 👎
github.com/dell/csm-hbnfs/nfs/nfs_service.go 86.02% (+0.55%) 236 (+2) 203 (+3) 33 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-hbnfs/nfs/nfs_service_test.go

@falfaroc falfaroc merged commit 570087c into main May 1, 2025
6 checks passed
@falfaroc falfaroc deleted the usr/falfaroc/reassignment-testing branch May 1, 2025 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants