Skip to content

Updated Access Zone Network Node Label Format#447

Merged
OliverChen557 merged 4 commits into
usr/atye/multi-tenantfrom
pvt/new-node-label
Aug 11, 2025
Merged

Updated Access Zone Network Node Label Format#447
OliverChen557 merged 4 commits into
usr/atye/multi-tenantfrom
pvt/new-node-label

Conversation

@OliverChen557

@OliverChen557 OliverChen557 commented Aug 11, 2025 •
edited by donatwork
Loading

Copy link
Copy Markdown
Contributor

Description

  • Updated AzNetwork node label format to eliminate limitation of 63 chars with the previous design
    E.g.
csi-isilon.dellemc.com/az-192.168.1.0-24-192.168.1.1

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1991

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested parsing new node labels (single IP and multiple IPs)

@OliverChen557 OliverChen557 marked this pull request as ready for review August 11, 2025 20:36
@OliverChen557 OliverChen557 merged commit 489d815 into usr/atye/multi-tenant Aug 11, 2025
6 checks passed
@OliverChen557 OliverChen557 deleted the pvt/new-node-label branch August 11, 2025 20:59
OliverChen557 added a commit that referenced this pull request Aug 12, 2025
@OliverChen557 @donatwork
Updated Access Zone Network Node Label Format (#447)
4e4a6bd 
Co-authored-by: Don Khan <don.khan@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

+1 more reviewer

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OliverChen557 @alikdell @santhoshatdell @donatwork