Some small UT additions#443
Merged
Merged
Conversation
hoppea2
approved these changes
Aug 11, 2025
alikdell
reviewed
Aug 11, 2025
| // return the createVolume response with actual array volume name | ||
| exportPath := path | ||
| if export != nil && export.Paths != nil { | ||
| if export.Paths != nil { |
Contributor
There was a problem hiding this comment.
Removing export nil check? That check seems helpful for unexpected nil value
Contributor
Author
There was a problem hiding this comment.
The code is within a block that ensures exports is never nil.
shaynafinocchiaro
approved these changes
Aug 11, 2025
hoppea2
pushed a commit
that referenced
this pull request
Aug 11, 2025
OliverChen557
pushed a commit
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase coverage of mount.go. Also some code cleanup to remove warnings flagged by static analysis.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: