Skip to content

Update TestPatchNodeLabels#435

Merged
atye merged 3 commits into
usr/atye/multi-tenantfrom
usr/atye/patchnodelables-ut
Aug 8, 2025
Merged

Update TestPatchNodeLabels#435
atye merged 3 commits into
usr/atye/multi-tenantfrom
usr/atye/patchnodelables-ut

Conversation

@atye

@atye atye commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

go test -timeout 120s -run ^TestPatchNodeLabels$ github.com/dell/csi-isilon/v2/service -v

=== RUN TestPatchNodeLabels
=== RUN TestPatchNodeLabels/success
csi-powerscale logger initiated. This should be called only once.
time="2025-08-08T09:23:49-04:00" level=debug msg="Node details after patching labels: &Node{ObjectMeta:{test-node 0 0001-01-01 00:00:00 +0000 UTC map[label1:value1] map[] [] [] []},Spec:NodeSpec{PodCIDR:,DoNotUseExternalID:,ProviderID:,Unschedulable:false,Taints:[]Taint{},ConfigSource:nil,PodCIDRs:[],},Status:NodeStatus{Capacity:ResourceList{},Allocatable:ResourceList{},Phase:,Conditions:[]NodeCondition{},Addresses:[]NodeAddress{},DaemonEndpoints:NodeDaemonEndpoints{KubeletEndpoint:DaemonEndpoint{Port:0,},},NodeInfo:NodeSystemInfo{MachineID:,SystemUUID:,BootID:,KernelVersion:,OSImage:,ContainerRuntimeVersion:,KubeletVersion:,KubeProxyVersion:,OperatingSystem:,Architecture:,Swap:nil,},Images:[]ContainerImage{},VolumesInUse:[],VolumesAttached:[]AttachedVolume{},Config:nil,RuntimeHandlers:[]NodeRuntimeHandler{},Features:nil,},}" file="/root/csi-powerscale/service/service.go:1136"
--- PASS: TestPatchNodeLabels (0.00s)
--- PASS: TestPatchNodeLabels/success (0.00s)
PASS
ok github.com/dell/csi-isilon/v2/service 0.032s

Comment thread service/service_test.go Outdated
Comment thread service/service.go
@atye atye merged commit 1071474 into usr/atye/multi-tenant Aug 8, 2025
5 of 6 checks passed
@atye atye deleted the usr/atye/patchnodelables-ut branch August 8, 2025 13:43
hoppea2 pushed a commit that referenced this pull request Aug 11, 2025
OliverChen557 pushed a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants