Skip to content

Support multi-tenant in controller publish and unpublish#431

Merged
OliverChen557 merged 17 commits into
usr/atye/multi-tenantfrom
usr/oliverchen557/controller-unpublish
Aug 7, 2025
Merged

Support multi-tenant in controller publish and unpublish#431
OliverChen557 merged 17 commits into
usr/atye/multi-tenantfrom
usr/oliverchen557/controller-unpublish

Conversation

@OliverChen557

@OliverChen557 OliverChen557 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Description

Support multi-tenant in controller publish and unpublish:

  • ControllerPublishVolume @hoppea2
    If the volume context contains reference to AzNetwork, use node labels to find matching network interface and add export using a new function with the correct IP address for the export.
  • ControllerUnpublishVolume @OliverChen557
    If the volume context contains reference to AzNetwork (get the context from the PV to determine if the new parameter is in the StorageClass), use node labels to find matching network interface and remove export using a new function with the correct IP address for the export.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Volume provision and checking debug logs. Logs are attached to story.

Comment thread service/controller.go Outdated
Comment thread service/controller.go
Comment thread service/controller.go
Comment thread service/controller.go
Comment thread service/controller.go
Comment thread service/isiService.go Outdated
Comment thread service/isiService.go Outdated
Comment thread service/isiService.go Outdated
@OliverChen557 OliverChen557 merged commit c1e44c7 into usr/atye/multi-tenant Aug 7, 2025
5 of 6 checks passed
@OliverChen557 OliverChen557 deleted the usr/oliverchen557/controller-unpublish branch August 7, 2025 20:46
hoppea2 added a commit that referenced this pull request Aug 11, 2025
Co-authored-by: Alexander Hoppe <Alexander.Hoppe@dell.com>
OliverChen557 added a commit that referenced this pull request Aug 12, 2025
Co-authored-by: Alexander Hoppe <Alexander.Hoppe@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants