Skip to content

CreateVolume adds the AZNetwork from the storage class to the volume context#429

Merged
enestvedto-dell merged 5 commits into
usr/atye/multi-tenantfrom
usr/enestvedto/multi-tenant
Aug 7, 2025
Merged

CreateVolume adds the AZNetwork from the storage class to the volume context#429
enestvedto-dell merged 5 commits into
usr/atye/multi-tenantfrom
usr/enestvedto/multi-tenant

Conversation

@enestvedto-dell

Copy link
Copy Markdown
Contributor

Description

  • This PR updates the CreateVolume function to add the AZNetwork from the storage class to the volume context which will then be available in other ControllerPublishVolume and ControllerUnpublishVolume calls.
  • Additionally, there is a small change to the unit-test make target. This removes the integration test from being run within the UT target and mirrors the UT behavior the common action runs.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
N/A

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

(Results attached to internal ticket)

  • Created pods and volumes using cert-csi
  • Manually provisioned volumes and pods and saw the updated attribute

Comment thread Makefile Outdated
Comment thread Makefile
Comment thread Makefile
@enestvedto-dell

Copy link
Copy Markdown
Contributor Author

Based on our recent discussion this is going to be merged in and keep the update to the make target.
CC @shaynafinocchiaro @donatwork

@enestvedto-dell enestvedto-dell force-pushed the usr/enestvedto/multi-tenant branch from beec3a8 to 93ec1e8 Compare August 7, 2025 14:30
Comment thread service/controller_test.go
@enestvedto-dell enestvedto-dell merged commit ef9712b into usr/atye/multi-tenant Aug 7, 2025
6 checks passed
@enestvedto-dell enestvedto-dell deleted the usr/enestvedto/multi-tenant branch August 7, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants