Skip to content

point to session fix commit of goisilon#240

Merged
nitesh3108 merged 2 commits into
mainfrom
session-response-html-json
Feb 12, 2024
Merged

point to session fix commit of goisilon#240
nitesh3108 merged 2 commits into
mainfrom
session-response-html-json

Conversation

@nitesh3108

@nitesh3108 nitesh3108 commented Feb 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR points to latest commit of gopowerscale, where session cookie re-authentication issue fix is provided.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1134

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Test results are already provided to gopowerscale PR.

HarishH-DELL
HarishH-DELL previously approved these changes Feb 9, 2024
View reviewed changes

@HarishH-DELL HarishH-DELL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chimanjain
chimanjain previously approved these changes Feb 9, 2024
View reviewed changes

@chimanjain chimanjain left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please check the unit test.

chimanjain
chimanjain approved these changes Feb 12, 2024
View reviewed changes

@chimanjain chimanjain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitesh3108 nitesh3108 merged commit 5904c05 into main Feb 12, 2024
cbartoszDell pushed a commit that referenced this pull request Mar 19, 2024
@nitesh3108 @cbartoszDell
point to session fix commit of goisilon (#240)
ff3658f 
* point to session fix commit of goisilon

* parsing html json reponse
cbartoszDell pushed a commit that referenced this pull request Mar 19, 2024
@nitesh3108 @cbartoszDell
point to session fix commit of goisilon (#240)
9abc095 
* point to session fix commit of goisilon

* parsing html json reponse
@AronAtDell AronAtDell deleted the session-response-html-json branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@meggm meggm Awaiting requested review from meggm

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

3 more reviewers

@chimanjain chimanjain chimanjain approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nitesh3108 @chimanjain @rajendraindukuri @HarishH-DELL