Set StandAlone proxy mode as default and remove configmap option#369
Merged
Conversation
…ix-1567-standalone-mode
* Update common-workflows.yaml * Update common-workflows.yaml * Update common-workflows.yaml * Add mock data * Update service_unit_test.go * Update service_unit_test.go * Add @v2.11.0 tag to csi_extension.feature * Create vsphere_test.go * Update node_connectivity_checker_test.go * Increase coverage of csi_ctrl_to_node_connectivity * Increase coverage of csi_ctrl_to_node_connectivity * Add UT for GetSCSILuns in vsphere.go * Update go.mod * Update csi_extension.feature * Create deletion_worker_test.go * Update deletion_worker_test.go * Update deletion_worker_test.go * Update deletion_worker_test.go * Add UT for AttachRDM in vsphere.go * Add UT for DetachRDM in vsphere.go * Add UT for NewVMHost in vsphere.go * Fix failure in TestNewVMHost * Add UT for RescanAllHba in vsphere.go * Update name of test case in vsphere.go * Adding Test for UpdateDriverConfigParams * Add more unit tests for vsphere.go * Added UT for ArrayMigrate * yaml lint updates * additional yaml lint fixes * yaml lint fixes * Adding test for SetArrayConfigEnvs * Adding test for getProxySettingsFromEnv function * Adding test for GetTransportProtocolFromEnv function * Adding Test for SetPollingFrequency and GetDriverName * Updating TestUpdateDriverConfigParams to increase coverage * Adding test for RegisterAdditionalServers * Updating TestRegisterAdditionalServers * Update service_unit_test.go * Add UT for nvmetcp in node.go * Add UT for nvmetcp in node.go * Update UT coverage * Fix UT * fixed helm test files yamllint issues * Add UT for vsphere in node.go * Update migration UT * Adding test for getNVMeTCPTargetsForMaskingView * Update service.feature * Add UT for node.go * Update UT for migration.go * Add UT for node.go * Update changes * fixed golint issues * gofumpt run for erroring files * further gofumpt runs for subsequent erroring files --------- Co-authored-by: Akshay Saini <akshay.saini@dell.com> Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com> Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com> Co-authored-by: root <root@master-1-dU11LI7DA0Bmb.domain> Co-authored-by: abrar-basha <abrar.basha@dell.com> Co-authored-by: Wilson Radadia <wilson.radadia@dell.com>
hoppea2
reviewed
Nov 26, 2024
hoppea2
left a comment
Contributor
There was a problem hiding this comment.
Please add more detailed description of the fix and automation test results once available
jooseppi-luna
suggested changes
Nov 26, 2024
jooseppi-luna
left a comment
Contributor
There was a problem hiding this comment.
There is no description in the PR, and there is no explanation of how this was tested. Please update the PR with both.
shanmydell
previously approved these changes
Nov 27, 2024
abhi16394
previously approved these changes
Nov 27, 2024
adarsh-dell
previously approved these changes
Nov 27, 2024
adarsh-dell
left a comment
There was a problem hiding this comment.
Change the Copyright year for some of the file that is not updated, rest looks good to me.
e94d19b
shanmydell
approved these changes
Nov 27, 2024
adarsh-dell
approved these changes
Nov 27, 2024
Collaborator
|
Is this impact Authorization? I guess so, I didn't hear much about this work. Please make sure Authorization V2 works with this changes. |
jooseppi-luna
previously requested changes
Nov 27, 2024
jooseppi-luna
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating PR description -- can you test with auth as well, since reverseproxy has to talk directly to auth?
Contributor
Author
|
@alikdell @jooseppi-luna, The team has successfully tested the changes with authorization. The results are now included in the PR description. |
alikdell
approved these changes
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the reverseproxy supported two modes:
The Linked mode was deprecated in CSM 1.9.0 due to lack of usage by customers, leaving only the StandAlone mode. https://github.com/dell/csm/issues/991
This PR sets the StandAlone proxy mode as the default and eliminates the ability to change it via configmap.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
cert-csi results
cert-csi-logs.txt.txt