Skip to content

Increase Code Coverage#374

Merged
mbasha-dell merged 56 commits into
bugfix-1567-standalone-modefrom
update-ut
Nov 26, 2024
Merged

Increase Code Coverage#374
mbasha-dell merged 56 commits into
bugfix-1567-standalone-modefrom
update-ut

Conversation

@sakshi-garg1

Copy link
Copy Markdown
Contributor

Description

Updating Unit test cases for powermax to increase coverage.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@AkshaySainiDell AkshaySainiDell changed the title Update common-workflows.yaml Increase Code Coverage Nov 18, 2024
Comment thread Makefile

# Run unit tests and skip the BDD tests
unit-test: golint check
( cd service; go clean -cache; CGO_ENABLED=0 GO111MODULE=on go test -skip TestGoDog -v -coverprofile=c.out ./... )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sakshi-garg1 Removing this -skip TestGoDog will result in running BDD tests as well as a part of unit-tests and it may fail

@mbasha-dell

Copy link
Copy Markdown
Contributor

actions passing, squashing and merging now

@mbasha-dell mbasha-dell merged commit ab1635a into bugfix-1567-standalone-mode Nov 26, 2024
@mbasha-dell mbasha-dell deleted the update-ut branch November 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants