Skip to content

Update Docker build to remove dependency on build script#333

Merged
tdawe merged 6 commits into
mainfrom
usr/tdawe/update-build
Oct 11, 2024
Merged

Update Docker build to remove dependency on build script#333
tdawe merged 6 commits into
mainfrom
usr/tdawe/update-build

Conversation

@tdawe

@tdawe tdawe commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updates build process for the CSI PowerMax driver and Reverse Proxy with following changes. This follows build processes for other drivers and modules:

  • Remove hardcoded golang version dependency from the reverse-proxy image build
  • Remove requirement to have all of the go libraries downloaded separately
  • Remove build.sh file and use common configuration
  • Build the reverse-proxy image as part of the docker targets for building the CSI driver
  • Set defaults using overrides.mk and docker.mk files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Successfully built all images with these changes
Additional tests executed by @OliverChen557 (see comment below)

@tdawe tdawe marked this pull request as ready for review October 9, 2024 19:43
@bharathsreekanth

bharathsreekanth commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

@tdawe As an optimization, is it possible that we don't delete packages immediately after deletion and use it. Ex. driver builds first and downloads 73 packages, and once its done they are removed. reverse-proxy builds next and it also downloads 73 packages, was thinking if we can avoid remove after driver build, then we dont need to pull again. Just a thought.

@OliverChen557

OliverChen557 commented Oct 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Tests done

  1. Image building was successful using make docker, which is updated on this branch.
  2. The following cert-csi tests were run successfully on the image built:

Environment

# oc version
Client Version: 4.17.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: 4.17.0
Kubernetes Version: v1.30.4

@tdawe tdawe merged commit dc2ab48 into main Oct 11, 2024
@tdawe tdawe deleted the usr/tdawe/update-build branch October 11, 2024 19:44
@shanmydell

shanmydell commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

@tdawe : Please update GH issue in all PRs, thanks, this has to be added to our release notes, @gallacher : FYR

Sahiba-Gupta pushed a commit that referenced this pull request Oct 15, 2024
@tdawe @Sahiba-Gupta
Update Docker build to remove dependency on build script (#333)
044bd92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@falfaroc falfaroc Awaiting requested review from falfaroc

@mjsdell mjsdell Awaiting requested review from mjsdell

4 more reviewers

@donatwork donatwork donatwork approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@OliverChen557 OliverChen557 OliverChen557 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tdawe @bharathsreekanth @OliverChen557 @shanmydell @donatwork @abhi16394