fix(ci): run istio gen-crds in autogenerated-check#2605
Merged
briantwatson merged 4 commits intomainfrom Apr 22, 2026
Merged
Conversation
briantwatson
commented
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI “autogenerated-check” composite action to also regenerate Istio/Gateway API CRD TypeScript types, closing a gap discovered during the Istio 1.29.1 update so that generated CRD artifacts are consistently kept in sync.
Changes:
- Run
uds run -f src/istio/tasks.yaml gen-crdsas part of the autogenerated check. - Update the failure message to instruct running both Pepr and Istio CRD generation tasks.
- Refresh generated Gateway API v1 TypeScript types/docs (
gateway-v1.ts) to match the current upstream CRD.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/pepr/operator/crd/generated/k8s/gateway-v1.ts |
Regenerated Gateway API v1 TS types/comments to reflect current CRD output. |
.github/actions/autogenerated-check/action.yaml |
Ensures CI regenerates Istio CRD types and reports the correct remediation steps when diffs are detected. |
briantwatson
commented
Apr 21, 2026
mjnagel
previously approved these changes
Apr 21, 2026
Contributor
mjnagel
left a comment
There was a problem hiding this comment.
This probably makes sense. We didn't do this previously really only because we generally don't need to 🫣. I think this is also a "problem" for the Prometheus CRD types that we generate if we want to change that now/later as well.
Contributor
Author
@mjnagel went ahead and added prometheus-stack. No diff on the tasks run |
joelmccoy
approved these changes
Apr 21, 2026
slaskawi
approved these changes
Apr 22, 2026
jasonwashburn
pushed a commit
that referenced
this pull request
Apr 28, 2026
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2026-04-28) ### Features * **CORE-27:** allow opt-in public clients ([#2598](#2598)) ([9af5ca7](9af5ca7)) * cycle gateways when istio gatewayTopology proxyProtocol changes ([#2595](#2595)) ([5eceba7](5eceba7)) ### Bug Fixes * **ci:** run istio gen-crds in autogenerated-check ([#2605](#2605)) ([40a1a97](40a1a97)) * handle apply properly for keycloak client secret ([#2627](#2627)) ([c227289](c227289)) * re-add keycloak client registration authpol ([#2614](#2614)) ([ebed871](ebed871)) * restore original loki write service account name ([#2599](#2599)) ([a5386e2](a5386e2)) * updating prometheus to use endpointslice ([#2594](#2594)) ([ba319c8](ba319c8)) ### Miscellaneous * add retry to multi-arch manifest check ([#2602](#2602)) ([4e8ba23](4e8ba23)) * **deps-dev:** bump postcss from 8.5.8 to 8.5.12 in /scripts/renovate ([#2615](#2615)) ([0922090](0922090)) * **deps:** update identity-config to 0.26.1 ([#2616](#2616)) ([fd105a2](fd105a2)) * **deps:** update istio to v1.29.2 ([#2587](#2587)) ([caddf35](caddf35)) * **deps:** update pepr to v1.1.6 ([#2607](#2607)) ([d9f2ae9](d9f2ae9)) * **deps:** update pepr to v1.1.7 ([#2611](#2611)) ([fd43cc3](fd43cc3)) * **deps:** update prometheus-stack ([#2546](#2546)) ([6812697](6812697)) * **deps:** update velero chart to v12.0.1 ([#2613](#2613)) ([1048ae9](1048ae9)) * swap bundles google idp saml signing cert ([#2609](#2609)) ([57795b9](57795b9)) * update istio CRDs to use v1 API ([#2606](#2606)) ([079c361](079c361)) ### Documentation * add 1.3.0 release notes ([#2633](#2633)) ([00468ab](00468ab)) * add keycloak admin handling doc ([#2597](#2597)) ([328d19c](328d19c)) * add troubleshooting for too many open files ([#2612](#2612)) ([0b64a05](0b64a05)) * update release notes for 1.2.1 ([#2603](#2603)) ([bfa8124](bfa8124)) * update release notes to include newest patches ([#2629](#2629)) ([d59ca81](d59ca81)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Working on istio v1 update I came across what I believe is a gap in our autogenerated-check.
We updated to 1.29.1 here: #2387
Related Issue
Relates to CORE-44
Type of change
Steps to Validate
n/a
Checklist before merging