Skip to content

chore: set helm buildflags the way Zarf does#1052

Merged
catsby merged 1 commit intomainfrom
set-helm-build-flags
Feb 12, 2025
Merged

chore: set helm buildflags the way Zarf does#1052
catsby merged 1 commit intomainfrom
set-helm-build-flags

Conversation

@catsby
Copy link
Copy Markdown
Contributor

@catsby catsby commented Dec 20, 2024

Description

Without setting these buildflags, some uds zarf commands could produce different results than directly using zarf of the same version. See details for example.

Details 
❯ uds version               
v0.20.0

❯ uds zarf version                    
v0.45.0

❯ zarf version                    
v0.45.0

❯ uds zarf dev find-images -f upstream
[... omitted things ...]
 NOTE  Using build directory .
     [... omitted things ...]
     ERROR:  unable to find images: could not render the Helm template for [some chart]: error
             generating helm chart template: chart requires kubeVersion: >=1.24.0-0 which is incompatible with
             Kubernetes v1.20.0

❯ zarf dev find-images -f upstream    
[... omitted things ...]
 NOTE  Using build directory .
  [... omitted things ...]
components:

  - name: [some chart]
    images:
      - alpine
      - nats:2.10.19-alpine
      - [other images]

In this PR we add the necessary variables and buildflags to get the correct results in a similar manner to how Zarf does.

Details 
❯ uds zarf dev find-images -f upstream    
[... omitted things ...]
 NOTE  Using build directory .
  [... omitted things ...]
components:

  - name: [some chart]
    images:
      - alpine
      - nats:2.10.19-alpine
      - [other images]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@catsby catsby requested a review from a team as a code owner December 20, 2024 22:23
@catsby catsby requested review from Racer159 and daveworth December 20, 2024 22:23
@catsby catsby force-pushed the set-helm-build-flags branch from b196964 to 83241eb Compare February 12, 2025 00:14
set helm buildflags the way Zarf does
47816d0 
Signed-off-by: catsby <clint@defenseunicorns.com>
@catsby catsby force-pushed the set-helm-build-flags branch from 83241eb to 47816d0 Compare February 12, 2025 16:13
@catsby catsby merged commit 8d31482 into main Feb 12, 2025
@catsby catsby deleted the set-helm-build-flags branch February 12, 2025 16:33
catsby pushed a commit that referenced this pull request Feb 12, 2025
Merge branch 'main' into perfsprint
5cfd7df 
* main:
  chore: set helm buildflags the way Zarf does (#1052)
  chore(deps): update github-actions (#1081)
  chore(deps): update github-actions (#1077)
  chore: copy over our own save-logs (#1075)
  chore(deps): update github-actions (#1072)
  chore: regroup and unlimit renovate (#1071)
  fix(deps): update module github.com/defenseunicorns/maru-runner to v0.5.0 (#1067)
  chore(config): migrate renovate config (#1069)
  chore: update zarf version ref to v0.48.1 (#1066)
  fix(deps): update golang.org/x/exp digest to 7d7fa50 (#1016)
  chore(deps): update actions/setup-go action to v5.2.0 (#1050)
  fix(deps): update module github.com/goccy/go-yaml to v1.15.12 (#1049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@Racer159 Racer159 Awaiting requested review from Racer159

@daveworth daveworth Awaiting requested review from daveworth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catsby @YrrepNoj