Skip to content

Conversation

@kouml
Copy link
Contributor

@kouml kouml commented Feb 14, 2020

When I following cifar tutorial, I couldn't execute cifar code directly.
so, I have two suggestions.

  1. Add $ pip install -r requirements.txt in cifar tutorial md file.
    If you didn't install requirements.txt in deepspeedexamples repo, you can't execute cifar tutorial directly.

  2. Move pillow library from deepspeedexamples/cifar10's requirements to deepspeed's requirements

When you use torchvision==0.4.0, pillow have to set 6.2.*.
If not, you failed whenever you import torchvision because of this bug.

Thank you.

@msftclas
Copy link

msftclas commented Feb 14, 2020

CLA assistant check
All CLA requirements met.

@ShadenSmith ShadenSmith requested a review from jeffra February 14, 2020 15:24
@ShadenSmith ShadenSmith added the documentation Improvements or additions to documentation label Feb 14, 2020
@jeffra
Copy link
Collaborator

jeffra commented Feb 14, 2020

We’re in the processing of fixing our docker build CI. That should be fixed shortly and then we can rerun these tests. Thank you for your contribution!

@jeffra jeffra merged commit bca2305 into deepspeedai:master Feb 15, 2020
kouml added a commit to kouml/DeepSpeed that referenced this pull request Apr 3, 2020
* add install requirements command line

* add pillow library to fix version

* modify to uppercase

Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
jeffra added a commit that referenced this pull request Sep 1, 2020
* add fake pt module to expose old deepspeed_utils and config

* switch to sys.modules instead of import to make it more explicit what we're doing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants