Samyamr/batchconfig #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like the formatting checks failed. @samyam can you add commit after running the code through our formatters? Instruction here: https://github.com/microsoft/DeepSpeed#prerequisites |
…ity and allowing for specifying only the micro batch size
…micro_batch, and adding a bunch of unit tests
348e461 to
84e0dce
Compare
tjruwase
reviewed
Feb 6, 2020
ShadenSmith
approved these changes
Feb 6, 2020
Contributor
ShadenSmith
left a comment
There was a problem hiding this comment.
Reviewing the test setup...will set Tunji/Jeff review the logical changes like you said.
tjruwase
approved these changes
Feb 7, 2020
Closed
Closed
kouml
pushed a commit
to kouml/DeepSpeed
that referenced
this pull request
Apr 3, 2020
* simplifying the batch config, using a single assert to test for validity and allowing for specifying only the micro batch size * Simplifying Batch Config, Adding ability to specify batch using just micro_batch, and adding a bunch of unit tests * ran formatting * Typo fixes and added the config file * reformatting * path fixes * removing print statements
jeffra
pushed a commit
to jeffra/DeepSpeed
that referenced
this pull request
May 15, 2020
* adding features to include zero-2
ShadenSmith
pushed a commit
that referenced
this pull request
May 16, 2020
* adding features to include zero-2
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Apr 28, 2021
* remove deepspeed.pt references * add codeowners file just like in DS
liamcli
pushed a commit
to determined-ai/DeepSpeed
that referenced
this pull request
Sep 27, 2021
Co-authored-by: Samuel Weinbach <samuel.weinbach@gmail.com>
delock
referenced
this pull request
in delock/DeepSpeedSYCLSupport
Sep 21, 2022
baodii
pushed a commit
to baodii/DeepSpeed
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and enhancements to Batch Configuration
@tjruwase @jeffra Please take a look at the logical changes to make sure they seem right to you. Also let me know if I am missing any test cases
@ShadenSmith Please make sure I am using the testing framework as it is supposed to be