Skip to content

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Dec 3, 2025

Horovod has not released a new version for a long time. The PR to support TF 2.20 (horovod/horovod#4302) has never been merged, I think it has been dead,

Summary by CodeRabbit

  • Chores

    • Simplified test workflow by removing specific installation steps.
  • Documentation

    • Added compatibility warning regarding Horovod and TensorFlow support in installation guide.

✏️ Tip: You can customize this high-level summary in your review settings.

Horovod has not released a new version for a long time. The PR to support TF 2.20 (horovod/horovod#4302) has never been merged, I think it has been dead,
@github-actions github-actions bot added the Docs label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.28%. Comparing base (2d5fa3c) to head (adfb0ce).
⚠️ Report is 3 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #5079      +/-   ##
==========================================
- Coverage   84.28%   84.28%   -0.01%     
==========================================
  Files         709      709              
  Lines       70561    70563       +2     
  Branches     3618     3620       +2     
==========================================
- Hits        59472    59471       -1     
- Misses       9923     9924       +1     
- Partials     1166     1168       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz closed this Dec 4, 2025
@njzjz njzjz reopened this Dec 4, 2025
@njzjz njzjz marked this pull request as ready for review December 4, 2025 16:51
Copilot AI review requested due to automatic review settings December 4, 2025 16:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Horovod tests from the CI pipeline due to Horovod's lack of maintenance and incompatibility with recent TensorFlow versions. The PR acknowledges that Horovod has not been actively maintained and the latest release doesn't support newer TensorFlow versions.

Key Changes:

  • Removed Horovod installation steps from the Python CI workflow
  • Added a warning in the installation documentation about Horovod's deprecated status

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test_python.yml Removes Horovod and setuptools installation commands from CI pipeline
doc/install/install-from-source.md Adds warning block informing users about Horovod's unmaintained status and lack of support for latest TensorFlow versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

📝 Walkthrough

Walkthrough

Removed setuptools and horovod installation steps from the Python test workflow. Added a compatibility warning in the installation documentation regarding Horovod's TensorFlow support status as of December 2025.

Changes

Cohort / File(s) Summary
CI Workflow
.github/workflows/test_python.yml
Removed pip install -U setuptools and pip install horovod --no-build-isolation installation steps.
Documentation
doc/install/install-from-source.md
Added warning admonition about Horovod compatibility and TensorFlow support, with link to conda-forge horovod-feedstock metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Review workflow step removals for impact on CI pipeline behavior
  • Verify warning content accuracy and placement in documentation

Possibly related PRs

Suggested reviewers

  • wanghan-iapcm

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: removing Horovod test steps from CI workflow and adding a deprecation warning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2215a06 and adfb0ce.

📒 Files selected for processing (2)
  • .github/workflows/test_python.yml (0 hunks)
  • doc/install/install-from-source.md (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/test_python.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.12)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@njzjz njzjz requested a review from wanghan-iapcm December 5, 2025 02:14
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@njzjz njzjz added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@njzjz njzjz added this pull request to the merge queue Dec 5, 2025
Merged via the queue into deepmodeling:devel with commit 0ad7cbf Dec 5, 2025
113 of 117 checks passed
@njzjz njzjz deleted the remove-horovod-tests branch December 5, 2025 16:29
ChiahsinChu pushed a commit to ChiahsinChu/deepmd-kit that referenced this pull request Dec 17, 2025
Horovod has not released a new version for a long time. The PR to
support TF 2.20 (horovod/horovod#4302) has never
been merged, I think it has been dead,

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
  * Simplified test workflow by removing specific installation steps.

* **Documentation**
* Added compatibility warning regarding Horovod and TensorFlow support
in installation guide.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants