-
Notifications
You must be signed in to change notification settings - Fork 584
CI: stop running Horovod tests #5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Horovod has not released a new version for a long time. The PR to support TF 2.20 (horovod/horovod#4302) has never been merged, I think it has been dead,
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #5079 +/- ##
==========================================
- Coverage 84.28% 84.28% -0.01%
==========================================
Files 709 709
Lines 70561 70563 +2
Branches 3618 3620 +2
==========================================
- Hits 59472 59471 -1
- Misses 9923 9924 +1
- Partials 1166 1168 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes Horovod tests from the CI pipeline due to Horovod's lack of maintenance and incompatibility with recent TensorFlow versions. The PR acknowledges that Horovod has not been actively maintained and the latest release doesn't support newer TensorFlow versions.
Key Changes:
- Removed Horovod installation steps from the Python CI workflow
- Added a warning in the installation documentation about Horovod's deprecated status
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test_python.yml |
Removes Horovod and setuptools installation commands from CI pipeline |
doc/install/install-from-source.md |
Adds warning block informing users about Horovod's unmaintained status and lack of support for latest TensorFlow versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughRemoved setuptools and horovod installation steps from the Python test workflow. Added a compatibility warning in the installation documentation regarding Horovod's TensorFlow support status as of December 2025. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0ad7cbf
Horovod has not released a new version for a long time. The PR to support TF 2.20 (horovod/horovod#4302) has never been merged, I think it has been dead, <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Simplified test workflow by removing specific installation steps. * **Documentation** * Added compatibility warning regarding Horovod and TensorFlow support in installation guide. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Horovod has not released a new version for a long time. The PR to support TF 2.20 (horovod/horovod#4302) has never been merged, I think it has been dead,
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.