fix: no pinning memory on CPU #4874

caic99 · 2025-08-07T11:23:41Z

This PR fixes the warning message when running on CPU:

torch/utils/data/dataloader.py:665: UserWarning: 'pin_memory' argument is set as true but no accelerator is found, then device pinned memory won't be used.
  warnings.warn(warn_msg)

Summary by CodeRabbit

Bug Fixes
- Improved memory handling by enabling memory pinning only when using non-CPU devices, which may enhance performance and stability when training on GPUs.

Copilot

Pull Request Overview

This PR fixes a PyTorch warning that occurs when pin_memory=True is set for DataLoader but the code is running on CPU, where pinned memory provides no benefit.

Conditionally sets pin_memory based on device type to avoid unnecessary warnings
Maintains pinned memory optimization for GPU/accelerator usage while disabling it for CPU

deepmd/pt/train/training.py

for more information, see https://pre-commit.ci

coderabbitai · 2025-08-07T11:25:22Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

The update changes the behavior of the pin_memory argument in the DataLoader within the get_dataloader_and_iter function. Now, pin_memory is enabled only when the device is not CPU, instead of being always enabled.

Changes

Cohort / File(s)	Change Summary
Conditional pin_memory in DataLoader `deepmd/pt/train/training.py`	Modified the DataLoader initialization to set `pin_memory=True` only if the device is not CPU; otherwise, it is set to `False`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 102a2ed and 29d71aa.

📒 Files selected for processing (1)

deepmd/pt/train/training.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)

GitHub Check: Test Python (2, 3.9)
GitHub Check: Test Python (6, 3.9)
GitHub Check: Test Python (4, 3.9)
GitHub Check: Test Python (5, 3.12)
GitHub Check: Test Python (2, 3.12)
GitHub Check: Test Python (4, 3.12)
GitHub Check: Test Python (3, 3.12)
GitHub Check: Test Python (5, 3.9)
GitHub Check: Test Python (6, 3.12)
GitHub Check: Test Python (1, 3.12)
GitHub Check: Test Python (3, 3.9)
GitHub Check: Test Python (1, 3.9)
GitHub Check: Build wheels for cp311-win_amd64
GitHub Check: Build wheels for cp310-manylinux_aarch64
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Build wheels for cp311-macosx_x86_64
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Build wheels for cp311-macosx_arm64
GitHub Check: Test C++ (false)
GitHub Check: Test C++ (true)
GitHub Check: Build C++ (cuda, cuda)
GitHub Check: Build C++ (cuda120, cuda)
GitHub Check: Build C++ (cpu, cpu)
GitHub Check: Build C++ (rocm, rocm)
GitHub Check: Build C++ (clang, clang)
GitHub Check: Build C library (2.14, >=2.5.0,<2.15, libdeepmd_c_cu11.tar.gz)
GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Analyze (python)
GitHub Check: Analyze (c-cpp)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-08-07T12:19:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (43504d3) to head (29d71aa).
⚠️ Report is 83 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4874      +/-   ##
==========================================
- Coverage   84.76%   84.71%   -0.06%     
==========================================
  Files         699      699              
  Lines       68077    68128      +51     
  Branches     3541     3542       +1     
==========================================
+ Hits        57708    57716       +8     
- Misses       9235     9277      +42     
- Partials     1134     1135       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Avoid specifying pin_memory for test DataLoaders to eliminate warnings when no accelerator is available. #4874  ## Summary by CodeRabbit * **Tests** * Updated test configurations to rely on default memory pinning behavior in data loading, improving compatibility across environments. * Simplified test setup parameters to reduce potential flakiness and align with framework defaults.

This PR fixes the warning message when running on CPU: ``` torch/utils/data/dataloader.py:665: UserWarning: 'pin_memory' argument is set as true but no accelerator is found, then device pinned memory won't be used. warnings.warn(warn_msg) ```  ## Summary by CodeRabbit * **Bug Fixes** * Improved memory handling by enabling memory pinning only when using non-CPU devices, which may enhance performance and stability when training on GPUs.  --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Avoid specifying pin_memory for test DataLoaders to eliminate warnings when no accelerator is available. deepmodeling#4874  ## Summary by CodeRabbit * **Tests** * Updated test configurations to rely on default memory pinning behavior in data loading, improving compatibility across environments. * Simplified test setup parameters to reduce potential flakiness and align with framework defaults.

fix: no pinning memory on CPU

c63bfe9

caic99 requested review from Copilot and njzjz August 7, 2025 11:23

github-actions bot added the Python label Aug 7, 2025

Copilot AI reviewed Aug 7, 2025

View reviewed changes

deepmd/pt/train/training.py Outdated Show resolved Hide resolved

[pre-commit.ci] auto fixes from pre-commit.com hooks

29d71aa

for more information, see https://pre-commit.ci

njzjz approved these changes Aug 7, 2025

View reviewed changes

njzjz added this pull request to the merge queue Aug 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025

njzjz added this pull request to the merge queue Aug 7, 2025

Merged via the queue into deepmodeling:devel with commit 3be0755 Aug 8, 2025
60 checks passed

caic99 mentioned this pull request Aug 26, 2025

fix: Avoid setting pin_memory in tests #4919

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: no pinning memory on CPU #4874

fix: no pinning memory on CPU #4874

Uh oh!

caic99 commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Aug 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: no pinning memory on CPU #4874

fix: no pinning memory on CPU #4874

Uh oh!

Conversation

caic99 commented Aug 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

coderabbitai bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

caic99 commented Aug 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 7, 2025 •

edited

Loading