fix: merge `get_np_precision` to `get_xp_precision` #4867

njzjz · 2025-08-04T13:57:57Z

get_xp_precision is more general and has more precisions (including bfloat16).

Summary by CodeRabbit

Refactor
- Improved internal handling of precision settings for numerical operations, streamlining how precision is determined. No changes to user-facing functionality.

Copilot

Pull Request Overview

This PR consolidates precision handling by replacing the get_np_precision function's implementation with a call to the more general get_xp_precision function, which supports additional precision types.

Removes direct import of GLOBAL_NP_FLOAT_PRECISION constant
Replaces manual precision mapping logic with delegation to get_xp_precision

deepmd/common.py

+    from deepmd.dpmodel.common import (
+        get_xp_precision,
+    )


coderabbitai · 2025-08-04T14:18:17Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

The get_np_precision function in deepmd/common.py was refactored to delegate precision resolution to the get_xp_precision function imported from deepmd.dpmodel.common. The previous inline precision mapping and error handling logic were removed, and the symbol GLOBAL_NP_FLOAT_PRECISION was added to the module's __all__ export list.

Changes

Cohort / File(s)	Change Summary
Precision Handling Refactor `deepmd/common.py`	Added `GLOBAL_NP_FLOAT_PRECISION` to `__all__`. Refactored `get_np_precision` to delegate precision resolution to `get_xp_precision` from `deepmd.dpmodel.common`, removing inline mapping and error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5725b5f and d8dfdfc.

📒 Files selected for processing (1)

deepmd/common.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

deepmd/common.py

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>

for more information, see https://pre-commit.ci

codecov · 2025-08-05T07:37:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (cec1944) to head (d8dfdfc).
⚠️ Report is 77 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #4867   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         699      699           
  Lines       68135    68126    -9     
  Branches     3542     3541    -1     
=======================================
- Hits        57721    57716    -5     
+ Misses       9279     9275    -4     
  Partials     1135     1135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

`get_xp_precision` is more general and has more precisions (including bfloat16).  ## Summary by CodeRabbit * **Refactor** * Improved internal handling of precision settings for numerical operations, streamlining how precision is determined. No changes to user-facing functionality.  --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

chore: merge get_np_precision to get_xp_precision

5725b5f

Copilot AI review requested due to automatic review settings August 4, 2025 13:57

github-actions bot added the Python label Aug 4, 2025

Copilot AI reviewed Aug 4, 2025

View reviewed changes

deepmd/common.py Show resolved Hide resolved

njzjz changed the title ~~chore: merge get_np_precision to get_xp_precision~~ fix: merge get_np_precision to get_xp_precision Aug 4, 2025

github-advanced-security bot found potential problems Aug 4, 2025

View reviewed changes

deepmd/common.py

Comment on lines +249 to +251

from deepmd.dpmodel.common import (

get_xp_precision,

)

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module

deepmd.dpmodel.common

Loading
begins an import cycle.

wanghan-iapcm approved these changes Aug 5, 2025

View reviewed changes

njzjz and others added 2 commits August 5, 2025 14:41

add GLOBAL_NP_FLOAT_PRECISION to all

5e88dcd

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>

[pre-commit.ci] auto fixes from pre-commit.com hooks

d8dfdfc

for more information, see https://pre-commit.ci

njzjz added this pull request to the merge queue Aug 5, 2025

Merged via the queue into deepmodeling:devel with commit 1fbe4c1 Aug 5, 2025
60 checks passed

njzjz deleted the merge-get-np-precision branch August 5, 2025 10:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: merge `get_np_precision` to `get_xp_precision` #4867

fix: merge `get_np_precision` to `get_xp_precision` #4867

Uh oh!

njzjz commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Check notice

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: merge get_np_precision to get_xp_precision #4867

fix: merge get_np_precision to get_xp_precision #4867

Uh oh!

Conversation

njzjz commented Aug 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Check notice

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: merge `get_np_precision` to `get_xp_precision` #4867

fix: merge `get_np_precision` to `get_xp_precision` #4867

njzjz commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 5, 2025 •

edited

Loading