Skip to content

Conversation

@A-LOST-WAPITI
Copy link
Contributor

@A-LOST-WAPITI A-LOST-WAPITI commented Aug 4, 2025

Summary by CodeRabbit

  • New Features

    • Automatic batch size handling is now enabled by default when creating a new DeepEval instance.
  • Documentation

    • Improved formatting consistency in model information and multi-task training guides by removing unnecessary blank lines.

…f argument `auto_batch_size` of `DeepEval` with paddle and pytorch backend
@github-actions github-actions bot added the Python label Aug 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 4, 2025

📝 Walkthrough

Walkthrough

The default value for the auto_batch_size parameter in the DeepEval class constructor was changed from False to True across three separate modules. No other logic or control flow related to this parameter was modified. Additionally, minor formatting cleanup was done in two markdown documentation files by removing trailing blank lines.

Changes

Cohort / File(s) Change Summary
DeepEval auto_batch_size Default Update
deepmd/dpmodel/infer/deep_eval.py, deepmd/pd/infer/deep_eval.py, deepmd/pt/infer/deep_eval.py
Changed the default value of the auto_batch_size parameter in the DeepEval class constructor from False to True. No other logic was changed.
Documentation Formatting Cleanup
doc/model/show-model-info.md, doc/train/multi-task-training.md
Removed trailing blank lines after list items and bullet points to improve markdown formatting without altering content or semantics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • wanghan-iapcm

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6239118 and 4073845.

📒 Files selected for processing (2)
  • doc/model/show-model-info.md (0 hunks)
  • doc/train/multi-task-training.md (0 hunks)
💤 Files with no reviewable changes (2)
  • doc/train/multi-task-training.md
  • doc/model/show-model-info.md
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@caic99 caic99 requested review from Copilot and njzjz August 4, 2025 03:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation inconsistency by updating the default value for the auto_batch_size parameter in DeepEval class docstrings across three backend implementations.

  • Updates docstring default value from False to True for auto_batch_size parameter
  • Ensures consistency between documentation and actual implementation behavior
  • Applies the fix across PyTorch, Paddle, and dpmodel backends

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
deepmd/pt/infer/deep_eval.py Updates docstring default value for auto_batch_size parameter in PyTorch backend
deepmd/pd/infer/deep_eval.py Updates docstring default value for auto_batch_size parameter in Paddle backend
deepmd/dpmodel/infer/deep_eval.py Updates docstring default value for auto_batch_size parameter in dpmodel backend

@github-actions github-actions bot added the Docs label Aug 4, 2025
@njzjz njzjz changed the base branch from master to devel August 4, 2025 03:40
@njzjz njzjz closed this Aug 6, 2025
@njzjz njzjz reopened this Aug 6, 2025
@njzjz njzjz enabled auto-merge August 6, 2025 08:38
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (b494a0d) to head (4073845).
⚠️ Report is 110 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #4865      +/-   ##
==========================================
- Coverage   84.79%   84.71%   -0.08%     
==========================================
  Files         698      699       +1     
  Lines       67817    68126     +309     
  Branches     3541     3541              
==========================================
+ Hits        57505    57716     +211     
- Misses       9178     9275      +97     
- Partials     1134     1135       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz added this pull request to the merge queue Aug 6, 2025
Merged via the queue into deepmodeling:devel with commit 102a2ed Aug 6, 2025
89 of 105 checks passed
ChiahsinChu pushed a commit to ChiahsinChu/deepmd-kit that referenced this pull request Dec 17, 2025
…f argument `auto_batch_size` of `DeepEval` with paddle and pytorch backend (deepmodeling#4865)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Automatic batch size handling is now enabled by default when creating
a new DeepEval instance.

* **Documentation**
* Improved formatting consistency in model information and multi-task
training guides by removing unnecessary blank lines.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: glwan <wanguolin@dp.tech>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants