fix(CI): prefer stable versions #4857
Conversation
Remove version `>=a.b.crc0` from dependencies. The stable version should be preferred. This prevents the installation of TensorFlow 2.20.0rc0 which breaks the CI. However, the incompatibility should still be fixed in the future. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
There was a problem hiding this comment.
Pull Request Overview
This PR removes release candidate (rc0) version specifiers from dependency declarations to prevent installation of unstable pre-release versions. The change addresses a CI breakage caused by TensorFlow 2.20.0rc0 which removed version information from header files.
- Remove
rc0suffixes from version constraints in dependency specifications - Update TensorFlow CPU version requirements to use stable releases only
- Modify documentation dependency to use stable myst-nb version
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updates myst-nb dependency to use stable version >=1.0.0 instead of >=1.0.0rc0 |
| backend/find_tensorflow.py | Removes rc0 from TensorFlow CPU version constraints for both CUDA 12.x and 11.x configurations |
| .github/workflows/package_c.yml | Updates TensorFlow version constraint in CI workflow to exclude release candidates |
📝 WalkthroughWalkthroughThis change updates version constraints by removing "rc0" (release candidate) suffixes from TensorFlow and myst-nb dependencies in the CI workflow, backend environment checks, and documentation requirements. No logic or control flow is altered, and no public interfaces are changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
🔇 Additional comments (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #4857 +/- ##
=======================================
Coverage 84.76% 84.77%
=======================================
Files 699 699
Lines 68077 68077
Branches 3541 3542 +1
=======================================
+ Hits 57708 57709 +1
Misses 9235 9235
+ Partials 1134 1133 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove version `>=a.b.crc0` from dependencies. The stable version should be preferred. This prevents the installation of TensorFlow 2.20.0rc0, which breaks the CI. However, the incompatibility should still be fixed in the future. TensorFlow 2.20.0rc0 removes the version information from the header files. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated version requirements for TensorFlow and myst-nb packages to use stable releases instead of release candidate versions in build and documentation workflows. * Adjusted dependency handling for TensorFlow CPU to ensure stable versions are used during build processes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Remove version
>=a.b.crc0from dependencies. The stable version should be preferred.This prevents the installation of TensorFlow 2.20.0rc0, which breaks the CI. However, the incompatibility should still be fixed in the future. TensorFlow 2.20.0rc0 removes the version information from the header files.
Summary by CodeRabbit