Skip to content

fix(CI): upgrade windows-2019 to windows-2022 #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njzjz merged 1 commit into from
Jun 11, 2025
Merged

fix(CI): upgrade windows-2019 to windows-2022 #4796

njzjz merged 1 commit into from
Jun 11, 2025
+1 −1

Conversation

@njzjz-bot
Copy link
Contributor

@njzjz-bot njzjz-bot commented Jun 10, 2025 •
edited by coderabbitai bot
Loading

The windows-2019 runner image will be removed soon. See: actions/runner-images#12045

Generated by the task: njzjz-bot/njzjz-bot#13.

Summary by CodeRabbit

  • Chores
    • Updated the Windows build environment in the GitHub Actions workflow to use a newer version.

@njzjz-bot
fix(CI): upgrade windows-2019 to windows-2022
4f0a9f3 
The windows-2019 runner image will be removed soon. See: actions/runner-images#12045

Generated by the task: njzjz-bot/njzjz-bot#13.
@njzjz-bot njzjz-bot force-pushed the gh_upgrade_win2019 branch from acb4a79 to 4f0a9f3 Compare June 10, 2025 17:44
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 10, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The GitHub Actions workflow configuration was updated to use the windows-2022 runner instead of windows-2019 for building wheels. No other workflow parameters or public entity declarations were altered.

Changes

File(s) Change Summary
.github/workflows/build_wheel.yml Updated Windows runner from windows-2019 to windows-2022 in the build matrix

Sequence Diagram(s)

No sequence diagram generated as the change is limited to workflow configuration.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c46dc7d and 4f0a9f3.

📒 Files selected for processing (1)
  • .github/workflows/build_wheel.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (25)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Test Python (5, 3.9)
  • GitHub Check: Test Python (6, 3.9)
  • GitHub Check: Test Python (5, 3.12)
  • GitHub Check: Test Python (4, 3.9)
  • GitHub Check: Test Python (6, 3.12)
  • GitHub Check: Test Python (3, 3.9)
  • GitHub Check: Test Python (4, 3.12)
  • GitHub Check: Test Python (3, 3.12)
  • GitHub Check: Test Python (1, 3.12)
  • GitHub Check: Test Python (1, 3.9)
  • GitHub Check: Test Python (2, 3.9)
  • GitHub Check: Test Python (2, 3.12)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Build C++ (cuda, cuda)
  • GitHub Check: Test C++ (true)
  • GitHub Check: Test C++ (false)
🔇 Additional comments (1)
.github/workflows/build_wheel.yml (1)

47-47:

Details

✅ Verification successful

Switch Windows runner to windows-2022
Updating the Windows image to windows-2022 aligns with the deprecation timeline and prevents upcoming CI failures.

Run a quick search to confirm no residual references to the old image remain:

🏁 Script executed:

rg -l 'windows-2019' .

Length of output: 22

No residual 'windows-2019' references found – Windows runner successfully updated to windows-2022
A search for windows-2019 returned no results, confirming the change is complete and CI will now use windows-2022.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@njzjz njzjz enabled auto-merge June 10, 2025 17:51
@njzjz njzjz added this pull request to the merge queue Jun 10, 2025
@codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (c46dc7d) to head (4f0a9f3).
⚠️ Report is 85 commits behind head on devel.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #4796      +/-   ##
==========================================
- Coverage   84.79%   84.79%   -0.01%     
==========================================
  Files         698      698              
  Lines       67819    67819              
  Branches     3542     3542              
==========================================
- Hits        57509    57506       -3     
  Misses       9178     9178              
- Partials     1132     1135       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into deepmodeling:devel with commit 6ddc2c9 Jun 11, 2025
60 checks passed
ChiahsinChu pushed a commit to ChiahsinChu/deepmd-kit that referenced this pull request Dec 17, 2025
@njzjz-bot @ChiahsinChu
fix(CI): upgrade windows-2019 to windows-2022 (deepmodeling#4796)
04619f4 
The windows-2019 runner image will be removed soon. See:
actions/runner-images#12045

Generated by the task: njzjz-bot/njzjz-bot#13.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the Windows build environment in the GitHub Actions workflow
to use a newer version.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njzjz njzjz njzjz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njzjz-bot @njzjz