fix(tf): fix UV resolution with TF 2.19 #4786

njzjz · 2025-06-05T16:28:59Z

Fix #4679

Summary by CodeRabbit

Chores
- Updated dependency metadata for TensorFlow 2.19.0 and TensorFlow-CPU 2.19.0 to improve compatibility and dependency resolution.

Fix deepmodeling#4679 Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

Copilot

Pull Request Overview

This PR adds UV dependency metadata entries for TensorFlow 2.19.0 to resolve issue #4679.

Introduces a tool.uv.dependency-metadata block for tensorflow 2.19.0.
Introduces a similar block for tensorflow-cpu 2.19.0.

Comments suppressed due to low confidence (1)

pyproject.toml:540

The tensorflow-cpu block includes GPU-specific extras (e.g., nvidia-cublas) which will pull unnecessary GPU dependencies for CPU-only installs. Remove or scope these GPU extras appropriately.

'nvidia-cublas-cu12 ==12.5.3.2 ; extra == "and-cuda",

pyproject.toml

coderabbitai · 2025-06-05T16:30:14Z

📝 Walkthrough

Walkthrough

The change adds two new dependency metadata entries for tensorflow and tensorflow-cpu version 2.19.0 to the pyproject.toml file. These entries specify detailed dependency requirements, including conditional and platform-specific dependencies, to improve package resolution and address a known issue.

Changes

File(s)	Change Summary
pyproject.toml	Added `[[tool.uv.dependency-metadata]]` entries for `tensorflow` and `tensorflow-cpu` version `2.19.0`, specifying detailed `requires-dist` lists with version constraints and platform conditions.

Assessment against linked issues

Objective	Addressed	Explanation
Add or update dependency metadata to resolve TensorFlow-related dependency resolution issues (#4679)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

pyproject.toml (2)

470-511: Consolidate duplicate dependency metadata
Both the tensorflow and tensorflow-cpu entries share an almost identical requires-dist list. Duplicating this list increases maintenance overhead and risks drift when future updates are needed. Consider extracting the common array into a shared snippet or generating both tables programmatically.

472-472: Clarify the issue reference
The inline comment # Fix https://github.com/deepmodeling/deepmd-kit/issues/4679 is useful, but a more descriptive annotation (e.g. # Adding TF 2.19 metadata to resolve issue #4679) will aid future readers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b1bbc2 and b0b7303.

📒 Files selected for processing (1)

pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (30)

GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
GitHub Check: Test Python (5, 3.9)
GitHub Check: Test Python (5, 3.12)
GitHub Check: Test Python (6, 3.9)
GitHub Check: Test Python (6, 3.12)
GitHub Check: Test Python (3, 3.12)
GitHub Check: Test Python (2, 3.9)
GitHub Check: Test Python (4, 3.12)
GitHub Check: Test Python (1, 3.9)
GitHub Check: Test Python (3, 3.9)
GitHub Check: Test Python (1, 3.12)
GitHub Check: Test Python (2, 3.12)
GitHub Check: Test Python (4, 3.9)
GitHub Check: Build C++ (cuda120, cuda)
GitHub Check: Build C++ (cpu, cpu)
GitHub Check: Build C++ (rocm, rocm)
GitHub Check: Build C++ (cuda, cuda)
GitHub Check: Build C++ (clang, clang)
GitHub Check: Test C++ (true)
GitHub Check: Test C++ (false)
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Analyze (python)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Analyze (c-cpp)
GitHub Check: Build wheels for cp310-manylinux_aarch64
GitHub Check: Build wheels for cp311-macosx_arm64
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Build wheels for cp311-win_amd64
GitHub Check: Build wheels for cp311-macosx_x86_64

🔇 Additional comments (2)

pyproject.toml (2)

477-481: Verify CUDA-extra conditions
You've appended CUDA-related packages under extra == "and-cuda". Please confirm that UV’s extras mechanism prevents these from installing by default on CPU-only platforms, and that end users won’t accidentally pull in GPU libs when they only need the CPU variant.

513-553: Approve TF CPU variant metadata
The tensorflow-cpu table correctly mirrors the GPU variant with conditional CUDA extras. This should ensure proper resolution for CPU-only installations under TF 2.19.0.

codecov · 2025-06-05T17:39:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (5b1bbc2) to head (b0b7303).
⚠️ Report is 85 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4786      +/-   ##
==========================================
- Coverage   84.80%   84.79%   -0.01%     
==========================================
  Files         698      698              
  Lines       67793    67793              
  Branches     3543     3543              
==========================================
- Hits        57489    57486       -3     
  Misses       9171     9171              
- Partials     1133     1136       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fix deepmodeling#4679  ## Summary by CodeRabbit - **Chores** - Updated dependency metadata for TensorFlow 2.19.0 and TensorFlow-CPU 2.19.0 to improve compatibility and dependency resolution.  Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

fix(tf): fix UV resolution with TF 2.19

b0b7303

Fix deepmodeling#4679 Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>

njzjz requested review from Copilot and wanghan-iapcm June 5, 2025 16:28

njzjz linked an issue Jun 5, 2025 that may be closed by this pull request

[BUG] Using uv to create a virtual environment dependency problem #4679

Closed

Copilot AI reviewed Jun 5, 2025

View reviewed changes

pyproject.toml Show resolved Hide resolved

coderabbitai bot reviewed Jun 5, 2025

View reviewed changes

wanghan-iapcm approved these changes Jun 10, 2025

View reviewed changes

wanghan-iapcm added this pull request to the merge queue Jun 10, 2025

Merged via the queue into deepmodeling:devel with commit c46dc7d Jun 10, 2025
60 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tf): fix UV resolution with TF 2.19 #4786

fix(tf): fix UV resolution with TF 2.19 #4786

Uh oh!

njzjz commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot commented Jun 5, 2025

Walkthrough

Changes

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(tf): fix UV resolution with TF 2.19 #4786

fix(tf): fix UV resolution with TF 2.19 #4786

Uh oh!

Conversation

njzjz commented Jun 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

coderabbitai bot commented Jun 5, 2025

Walkthrough

Changes

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

njzjz commented Jun 5, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 5, 2025 •

edited

Loading