fix(jax): set `default_matmul_precision` to `tensorfloat32` #4726

njzjz · 2025-05-07T16:05:08Z

See jax-ml/jax#24909. Without setting this flag, the precision will become very low, which seems to be a bug (the documentation says the GPU uses tensorfloat32 or float32, but the default behavior seems wrong...).
See https://docs.jax.dev/en/latest/_autosummary/jax.default_matmul_precision.html for what this option is.

Summary by CodeRabbit

Chores
- Updated environment configuration to set default matrix multiplication precision to "tensorfloat32" for improved performance with JAX.

See jax-ml/jax#24909. Without setting this flag, the precision will become very low, which seems to be a bug. See https://docs.jax.dev/en/latest/_autosummary/jax.default_matmul_precision.html for what this option is. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>

Copilot

Pull Request Overview

This PR addresses an issue with the JAX matmul precision by configuring the default value to "tensorfloat32" to prevent unintentional low precision.

Sets the default matmul precision flag to "tensorfloat32"
Adds a reference to the related GitHub issue for context

coderabbitai · 2025-05-07T16:07:07Z

📝 Walkthrough

Walkthrough

A configuration update was made in the JAX environment setup to set the default matrix multiplication precision to "tensorfloat32". This change involves a single line addition with an explanatory comment referencing a related JAX issue. No other logic or public interfaces were altered.

Changes

File(s)	Change Summary
deepmd/jax/env.py	Added configuration to set JAX's default matrix multiplication precision to "tensorfloat32" with a comment.

Suggested reviewers

iProzd
wanghan-iapcm

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

deepmd/jax/env.py (1)

15-15: Nit: correct the GitHub issue URL
The comment refers to https://github.com/jax-ml/jax/issues/24909, but the official JAX repository is under google/jax. Please update the link to https://github.com/google/jax/issues/24909 to avoid confusion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01c3c16 and 1ac6b43.

📒 Files selected for processing (1)

deepmd/jax/env.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (29)

GitHub Check: Test Python (6, 3.12)
GitHub Check: Test Python (6, 3.9)
GitHub Check: Test Python (5, 3.12)
GitHub Check: Test Python (5, 3.9)
GitHub Check: Test Python (4, 3.12)
GitHub Check: Build wheels for cp310-manylinux_aarch64
GitHub Check: Test Python (4, 3.9)
GitHub Check: Test Python (3, 3.12)
GitHub Check: Build wheels for cp311-win_amd64
GitHub Check: Build C++ (clang, clang)
GitHub Check: Build C++ (rocm, rocm)
GitHub Check: Test Python (3, 3.9)
GitHub Check: Build wheels for cp311-macosx_arm64
GitHub Check: Build wheels for cp311-macosx_x86_64
GitHub Check: Test Python (2, 3.12)
GitHub Check: Build C++ (cuda120, cuda)
GitHub Check: Test Python (2, 3.9)
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Analyze (python)
GitHub Check: Build C++ (cuda, cuda)
GitHub Check: Test Python (1, 3.12)
GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
GitHub Check: Build C++ (cpu, cpu)
GitHub Check: Build wheels for cp311-manylinux_x86_64
GitHub Check: Test Python (1, 3.9)
GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
GitHub Check: Analyze (c-cpp)
GitHub Check: Test C++ (false)
GitHub Check: Test C++ (true)

🔇 Additional comments (1)

deepmd/jax/env.py (1)

15-16: Explicitly set JAX matmul precision to tensorfloat32
This change aligns with the JAX documentation and resolves issue #24909, ensuring that GPU matrix multiplications use higher‐precision tensorfloat32 by default.

codecov · 2025-05-07T16:54:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (01c3c16) to head (1ac6b43).
⚠️ Report is 80 commits behind head on devel.

Additional details and impacted files

@@           Coverage Diff           @@
##            devel    #4726   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         696      696           
  Lines       67264    67265    +1     
  Branches     3541     3541           
=======================================
+ Hits        57047    57048    +1     
  Misses       9085     9085           
  Partials     1132     1132

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ling#4726) See jax-ml/jax#24909. Without setting this flag, the precision will become very low, which seems to be a bug (the documentation says the GPU uses tensorfloat32 or float32, but the default behavior seems wrong...). See https://docs.jax.dev/en/latest/_autosummary/jax.default_matmul_precision.html for what this option is.  ## Summary by CodeRabbit - **Chores** - Updated environment configuration to set default matrix multiplication precision to "tensorfloat32" for improved performance with JAX.  Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn> (cherry picked from commit 17da9d2)

njzjz requested review from Copilot and wanghan-iapcm May 7, 2025 16:05

Copilot AI reviewed May 7, 2025

View reviewed changes

github-actions bot added the Python label May 7, 2025

coderabbitai bot reviewed May 7, 2025

View reviewed changes

wanghan-iapcm approved these changes May 8, 2025

View reviewed changes

njzjz added this pull request to the merge queue May 8, 2025

Merged via the queue into deepmodeling:devel with commit 17da9d2 May 8, 2025
60 checks passed

njzjz deleted the jax_default_matmul_precision branch May 8, 2025 16:41

njzjz mentioned this pull request May 15, 2025

[BUG] DPA3 model converted from Torch to JAX backend not working in LAMMPS #4740

Closed

njzjz added this to the v3.0.3 milestone May 21, 2025

coderabbitai bot mentioned this pull request May 21, 2025

[r3.0] release v3.0.3 #4759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(jax): set `default_matmul_precision` to `tensorfloat32` #4726

fix(jax): set `default_matmul_precision` to `tensorfloat32` #4726

Uh oh!

njzjz commented May 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot commented May 7, 2025

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented May 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(jax): set default_matmul_precision to tensorfloat32 #4726

fix(jax): set default_matmul_precision to tensorfloat32 #4726

Uh oh!

Conversation

njzjz commented May 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

coderabbitai bot commented May 7, 2025

Walkthrough

Changes

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(jax): set `default_matmul_precision` to `tensorfloat32` #4726

fix(jax): set `default_matmul_precision` to `tensorfloat32` #4726

njzjz commented May 7, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 7, 2025 •

edited

Loading