Reviewing files that changed from the base of the PR and between 2e4da81 and 6c2032f.

• .github/workflows/build_cc.yml (1 hunks)
• source/cmake/googletest.cmake.in (1 hunks)

• GitHub Check: Test Python (6, 3.12)
• GitHub Check: Test Python (6, 3.9)
• GitHub Check: Test Python (5, 3.12)
• GitHub Check: Test Python (5, 3.9)
• GitHub Check: Test Python (4, 3.12)
• GitHub Check: Build wheels for cp310-manylinux_aarch64
• GitHub Check: Test Python (4, 3.9)
• GitHub Check: Build wheels for cp311-win_amd64
• GitHub Check: Test Python (3, 3.12)
• GitHub Check: Test Python (3, 3.9)
• GitHub Check: Test Python (2, 3.12)
• GitHub Check: Build wheels for cp311-macosx_x86_64
• GitHub Check: Build C++ (rocm, rocm)
• GitHub Check: Build wheels for cp311-manylinux_x86_64
• GitHub Check: Test Python (2, 3.9)
• GitHub Check: Build C++ (cuda120, cuda)
• GitHub Check: Analyze (python)
• GitHub Check: Test Python (1, 3.12)
• GitHub Check: Build wheels for cp311-manylinux_x86_64
• GitHub Check: Test C++ (false)
• GitHub Check: Build C++ (cuda, cuda)
• GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
• GitHub Check: Test Python (1, 3.9)
• GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
• GitHub Check: Analyze (c-cpp)
• GitHub Check: Test C++ (true)

source/cmake/googletest.cmake.in (1)

1-1:

Details

✅ Verification successful

Approved: Updated minimum CMake version requirement.

Updating from CMake 2.8.2 to 3.5 is a good step toward modern CMake practices. Version 3.5 provides better module support and improved generator expressions compared to 2.8.2.

Since the PR title mentions "fix compatibility with CMake 4.0", please verify that CMake 3.5 is sufficient to ensure compatibility with CMake 4.0. While this is a significant version upgrade from 2.8.2, it's still notably below 4.0.

---

🏁 Script executed:

#!/bin/bash
# Check for any CMake 4.0 specific features used in the project that might require explicit version requirements
grep -r "cmake_minimum_required" --include="*.cmake" --include="CMakeLists.txt" .

Length of output: 781

---

Verified: CMake minimum version requirement is acceptable

After reviewing the codebase, we see that several other CMake files already require versions well above 3.5 (e.g., 3.7, 3.9, 3.16, 3.21, and 3.23). No CMake 4.0‑exclusive features are in use anywhere. Thus, updating source/cmake/googletest.cmake.in to 3.5 continues to ensure compatibility—even under CMake 4.0—and aligns with overall project practices.

• File Updated: source/cmake/googletest.cmake.in now uses version 3.5.
• Other References in Project:
  • ./examples/infer_water/CMakeLists.txt uses 3.7
  • ./source/CMakeLists.txt uses 3.16, 3.21, and 3.23
  • Other test and plugin directories require versions ≥3.9

Given that the project’s top-level CMake requirements are higher than 3.5, this isolated update does not pose any compatibility risks with CMake 4.0.

.github/workflows/build_cc.yml (1)

55-55:

Details

❓ Verification inconclusive

Approved: Updated ROCm repository version.

Updating from ROCm 5.3 to 6.3 ensures compatibility with newer AMD GPUs and provides access to the latest optimizations and features in the ROCm ecosystem.

Please verify that ROCm 6.3 is compatible with the CMake version (3.5) specified in the project. Newer ROCm versions sometimes require newer build tools.

---

🏁 Script executed:

#!/bin/bash
# Check if there are any other references to ROCm versions that might need updating
grep -r "repo.radeon.com/rocm/apt/" --include="*.yml" --include="*.sh" .

Length of output: 234

---

Action Required: Confirm ROCm 6.3 Compatibility with CMake 3.5

• The updated ROCm repository reference (v6.3) is the only occurrence in the repository.
• Please ensure that the ROCm 6.3 toolchain is fully compatible with the project’s minimum CMake version (3.5). Some ROCm 6.3 components may rely on features introduced in later CMake versions.
• If compatibility issues are observed, consider updating the CMake minimum requirement in the project (e.g., to 3.10 or later).