Fix version in DeePMDConfigVersion.cmake #4577

RMeli · 2025-02-03T17:05:01Z

The double quotes end up as follows in DeePMDConfigVersion.cmake:

set(PACKAGE_VERSION "$<IF:?:"0.0.0">")

This result in the following warning:

CMake Error (dev) at /opt/cp2k-toolchain/install/deepmd-kit-3.0.1/lib/cmake/DeePMD/DeePMDConfigVersion.cmake:10:                                             
  Syntax Warning in cmake code at column 30                                                                                                                                                                                                                                                                                
  Argument not separated from preceding token by whitespace.                                                                                                 
Call Stack (most recent call first):                                                                                                                         
  CMakeLists.txt:703 (find_package)                                                                                                                          
This error is for project developers. Use -Wno-error=dev to suppress it.

Summary by CodeRabbit

Bug Fixes
- Improved the project’s version handling to ensure that when no version is provided, a reliable default is used, resulting in more consistent and accurate version information for end-users.

coderabbitai · 2025-02-03T17:06:39Z

📝 Walkthrough

Walkthrough

The pull request updates the CMake configuration by modifying the versioning expression in the write_basic_package_version_file call within source/CMakeLists.txt. The change removes quotes around the default value 0.0.0, ensuring that when GIT_SUMM is not defined, the version is correctly processed as a numeric value rather than a string.

Changes

File	Change Summary
source/CMakeLists.txt	Modified the versioning expression in `write_basic_package_version_file` to remove quotes around the default version.

Suggested labels

LAMMPS

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90e83b3 and 576b8d4.

📒 Files selected for processing (1)

source/CMakeLists.txt (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

source/CMakeLists.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

njzjz

LGTM, but need to rebase.

We only accept new PRs on the devel branch.

RMeli · 2025-02-04T09:02:30Z

Sorry, my bad. I'll fix the conflicts.

We only accept new PRs on the devel branch.

It would help to avoid these issues if the devel branch was the default branch on GitHub.

codecov · 2025-02-04T14:13:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (63c4772) to head (576b8d4).
Report is 63 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4577      +/-   ##
==========================================
- Coverage   84.61%   84.61%   -0.01%     
==========================================
  Files         680      680              
  Lines       64467    64466       -1     
  Branches     3538     3538              
==========================================
- Hits        54546    54545       -1     
+ Misses       8780     8779       -1     
- Partials     1141     1142       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

njzjz · 2025-02-05T01:45:14Z

It would help to avoid these issues if the devel branch was the default branch on GitHub.

This can be discussed, @wanghan-iapcm

The double quotes end up as follows in `DeePMDConfigVersion.cmake`: ```cmake set(PACKAGE_VERSION "$<IF:?:"0.0.0">") ``` This result in the following warning: ``` CMake Error (dev) at /opt/cp2k-toolchain/install/deepmd-kit-3.0.1/lib/cmake/DeePMD/DeePMDConfigVersion.cmake:10: Syntax Warning in cmake code at column 30 Argument not separated from preceding token by whitespace. Call Stack (most recent call first): CMakeLists.txt:703 (find_package) This error is for project developers. Use -Wno-error=dev to suppress it. ```  ## Summary by CodeRabbit - **Bug Fixes** - Improved the project’s version handling to ensure that when no version is provided, a reliable default is used, resulting in more consistent and accurate version information for end-users.  (cherry picked from commit 8104841)

wanghan-iapcm requested a review from njzjz February 4, 2025 06:21

njzjz changed the base branch from r3.0 to devel February 4, 2025 06:31

njzjz approved these changes Feb 4, 2025

View reviewed changes

RMeli added 2 commits February 4, 2025 10:05

cmake fix

5a95427

Merge branch 'devel' into patch-1

576b8d4

njzjz enabled auto-merge February 4, 2025 13:30

njzjz added this pull request to the merge queue Feb 4, 2025

Merged via the queue into deepmodeling:devel with commit 8104841 Feb 4, 2025
60 checks passed

RMeli deleted the patch-1 branch February 4, 2025 16:37

njzjz added this to the v3.0.2 milestone Feb 9, 2025

coderabbitai bot mentioned this pull request Feb 10, 2025

[r3.0] release v3.0.2 #4589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix version in DeePMDConfigVersion.cmake #4577

Fix version in DeePMDConfigVersion.cmake #4577

Uh oh!

RMeli commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

Walkthrough

Changes

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

njzjz left a comment

Uh oh!

RMeli commented Feb 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

njzjz commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix version in DeePMDConfigVersion.cmake #4577

Fix version in DeePMDConfigVersion.cmake #4577

Uh oh!

Conversation

RMeli commented Feb 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

njzjz left a comment

Choose a reason for hiding this comment

Uh oh!

RMeli commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

njzjz commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RMeli commented Feb 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

RMeli commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading