-
Notifications
You must be signed in to change notification settings - Fork 584
fix(dp): fix dp seed in dpa2 descriptor #3957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant InitSubclassParamsFunction as init_subclass_params
participant ChildSeedFunction as child_seed
User->>InitSubclassParamsFunction: Call with (sub_data, sub_class, seed)
InitSubclassParamsFunction->>ChildSeedFunction: Request seed for instance 1 (seed, 3)
ChildSeedFunction->>InitSubclassParamsFunction: Return seed value
InitSubclassParamsFunction->>ChildSeedFunction: Request seed for instance 2 (seed, 4)
ChildSeedFunction->>InitSubclassParamsFunction: Return seed value
InitSubclassParamsFunction->>User: Function proceeds with precision and seed values
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3957 +/- ##
==========================================
- Coverage 82.83% 82.83% -0.01%
==========================================
Files 520 520
Lines 50832 50832
Branches 3011 3015 +4
==========================================
- Hits 42109 42106 -3
- Misses 7790 7791 +1
- Partials 933 935 +2 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `seed` parameter to enhance the initialization process, enabling more controlled and reproducible results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a `seed` parameter to enhance the initialization process, enabling more controlled and reproducible results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
seedparameter to enhance the initialization process, enabling more controlled and reproducible results.