breaking: deprecate set_prefix
#3753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix deepmodeling#3477. Deprecate `set_prefix` in the training parameter and `--set-prefix` in CLI. It has been broken since several years ago, and dpdata only supports `set`. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/dpgen
that referenced
this pull request
May 6, 2024
njzjz
added a commit
to njzjz/dpgen2
that referenced
this pull request
May 6, 2024
njzjz
added a commit
to njzjz/tutorials
that referenced
this pull request
May 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3753 +/- ##
==========================================
- Coverage 82.26% 82.25% -0.01%
==========================================
Files 513 513
Lines 47634 47653 +19
Branches 2979 2979
==========================================
+ Hits 39186 39199 +13
- Misses 7537 7543 +6
Partials 911 911 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
pushed a commit
to deepmodeling/dpgen2
that referenced
this pull request
May 7, 2024
See: - deepmodeling/deepmd-kit#3477 - deepmodeling/deepmd-kit#3753 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed an unused configuration parameter from the training settings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
wanghan-iapcm
approved these changes
May 7, 2024
iProzd
approved these changes
May 7, 2024
wanghan-iapcm
added a commit
to deepmodeling/dpgen
that referenced
this pull request
May 7, 2024
See: - deepmodeling/deepmd-kit#3477 - deepmodeling/deepmd-kit#3753 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed the `"set_prefix": "set"` attribute across various JSON and YAML configuration files, streamlining data handling and batch processing setups. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
njzjz
added a commit
to deepmodeling/tutorials
that referenced
this pull request
Aug 9, 2024
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
Fix deepmodeling#3477. Deprecate `set_prefix` in the training parameter and `--set-prefix` in CLI. It has been broken since several years ago, and dpdata only supports `set`. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3477.
Deprecate
set_prefixin the training parameter and--set-prefixin CLI. It has been broken since several years ago, and dpdata only supportsset.