refactor: split Model and AtomicModel #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model is not inherited from AtomicModel anymore. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3438 +/- ##
==========================================
+ Coverage 77.01% 77.29% +0.27%
==========================================
Files 427 427
Lines 36790 36915 +125
Branches 1621 1621
==========================================
+ Hits 28335 28533 +198
+ Misses 7587 7514 -73
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
…eepmd-kit into split-model-atomic-model
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Mar 10, 2024
anyangml
reviewed
Mar 11, 2024
anyangml
approved these changes
Mar 11, 2024
iProzd
approved these changes
Mar 11, 2024
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Mar 11, 2024
After deepmodeling#3438, `model_def_script` is no more saved in AtomicModel. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
After #3438, `model_def_script` is no more saved in AtomicModel. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
This PR refactors the serialization/ deserialization in LinearEnergyAtomicModel using the plugin mechanism introduced in #3438 . --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model is not inherited from AtomicModel anymore.