fix: replace all distinguished types by mixed types. #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3289 +/- ##
==========================================
+ Coverage 74.99% 75.00% +0.01%
==========================================
Files 392 392
Lines 33759 33757 -2
Branches 1604 1604
==========================================
+ Hits 25319 25321 +2
+ Misses 7579 7575 -4
Partials 861 861 ☔ View full report in Codecov by Sentry. |
iProzd
reviewed
Feb 18, 2024
njzjz
reviewed
Feb 18, 2024
njzjz
reviewed
Feb 18, 2024
njzjz
approved these changes
Feb 19, 2024
anyangml
approved these changes
Feb 19, 2024
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Feb 19, 2024
It was broken by deepmodeling#3289, which replaced distinguished types by mixed types but didn't change the input. Add tests for two types. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
It was broken by #3289, which replaced distinguished types by mixed types but didn't change the input. Add tests for two types. --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.