feat: mace model in batch #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
|
Hello @njzjz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 90.72% 90.46% -0.27%
==========================================
Files 5 5
Lines 507 493 -14
==========================================
- Hits 460 446 -14
Misses 47 47 ☔ View full report in Codecov by Sentry. |
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Nov 28, 2024
Copied from deepmodeling/deepmd-gnn#27. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
github-merge-queue bot
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Nov 30, 2024
Copied from deepmodeling/deepmd-gnn#27. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced the robustness of the testing framework to ensure consistent model output across multiple frames of input data. - Added assertions to validate output equivalence for the first and second frames. - **Tests** - Adjusted the testing methods to accommodate changes in input dimensionality and ensure proper validation of model behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.